Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smoketest: T6592: remove unused "import os" #3874

Merged
merged 1 commit into from
Jul 28, 2024
Merged

smoketest: T6592: remove unused "import os" #3874

merged 1 commit into from
Jul 28, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Jul 25, 2024

Change Summary

remove unused "import os"

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

smoketests

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po c-po requested a review from a team as a code owner July 25, 2024 09:16
@c-po
Copy link
Member Author

c-po commented Jul 25, 2024

@Mergifyio backport circinus

@c-po c-po enabled auto-merge July 25, 2024 09:16
@github-actions GitHub Actions
Copy link

👍
No issues in PR Title / Commit Title

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 25, 2024 •
edited
Loading

backport circinus

✅ Backports have been created

@github-actions GitHub Actions
Copy link

❌
warning: Unused import os in smoketest/scripts/cli/test_interfaces_l2tpv3.py:17.

@github-actions GitHub Actions
Copy link

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed

@c-po c-po merged commit 358aaa1 into vyos:current Jul 28, 2024
13 of 14 checks passed
@mergify mergify bot mentioned this pull request Jul 28, 2024
Merged
12 tasks
@c-po c-po deleted the unused-import branch July 28, 2024 16:56
c-po added a commit that referenced this pull request Jul 29, 2024
@c-po
Merge pull request #3894 from vyos/mergify/bp/circinus/pr-3874
e90fd5c 
smoketest: T6592: remove unused "import os" (backport #3874)
@c-po
Copy link
Member Author

c-po commented Jul 31, 2024

@Mergifyio backport sagitta

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 31, 2024 •
edited
Loading

backport sagitta

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jul 31, 2024
Merged
12 tasks
c-po added a commit that referenced this pull request Aug 1, 2024
@c-po
Merge pull request #3914 from vyos/mergify/bp/sagitta/pr-3874
e61a175 
smoketest: T6592: remove unused "import os" (backport #3874)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fett0 fett0 fett0 approved these changes

@sever-sever sever-sever sever-sever approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin was automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev was automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc was automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro was automatically assigned from vyos/reviewers

@nicolas-fort nicolas-fort Awaiting requested review from nicolas-fort nicolas-fort was automatically assigned from vyos/reviewers

Assignees

@c-po c-po

Labels
backport current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-po @sever-sever @fett0