Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoketest: T6614: initial support for op-mode command testing (backport #3888) #3893

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 28, 2024

Change Summary

We currently lack behind testing OP-mode commands with the smoketest framework.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Smoketests

Smoketest result

cpo@LR2.wue3:~$ /usr/libexec/vyos/tests/smoke/cli/test_op-mode_show.py
test_op_mode_show_version (__main__.TestOPModeShow.test_op_mode_show_version) ... ok
test_op_mode_show_vrf (__main__.TestOPModeShow.test_op_mode_show_vrf) ... ok

----------------------------------------------------------------------
Ran 2 tests in 1.469s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #3888 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner July 28, 2024 15:12
@mergify mergify bot requested review from dmbaturin, sarthurdev and zdc July 28, 2024 15:12
@mergify mergify bot requested review from jestabro, fett0 and nicolas-fort July 28, 2024 15:12
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Jul 28, 2024
Copy link

👍
No issues in PR Title / Commit Title

Copy link


warning: Unused import os in smoketest/scripts/cli/test_interfaces_l2tpv3.py:17.

@c-po c-po enabled auto-merge July 29, 2024 05:34
@c-po c-po merged commit eb61f28 into sagitta Jul 29, 2024
7 of 8 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-3888 branch July 29, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sagitta VyOS 1.4 LTS
Development

Successfully merging this pull request may close these issues.

3 participants