Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6949: adds blackbox exporter #4255

Merged
merged 8 commits into from
Dec 31, 2024
Merged

T6949: adds blackbox exporter #4255

merged 8 commits into from
Dec 31, 2024

Conversation

nvollmar
Copy link
Contributor

@nvollmar nvollmar commented Dec 24, 2024

Change Summary

Adds Prometheus Blackbox Exporter

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

monitoring

Proposed changes

Adding Blackbox Exporter allows Prometheus to probe endpoints over HTTP, HTTPS, DNS, TCP, ICMP and gRPC.
This can deliver metrics about upstream connectivity, dns service responsiveness etc.

How to test

Enable blackbox_exporter

set service monitoring prometheus blackbox-exporter listen-address 0.0.0.0

Then check service is running

curl localhost:9115

Smoketest result

vyos:~$ /usr/libexec/vyos/tests/smoke/cli/test_service_monitoring_prometheus.py
test_01_node_exporter (__main__.TestMonitoringPrometheus.test_01_node_exporter) ... ok
test_02_frr_exporter (__main__.TestMonitoringPrometheus.test_02_frr_exporter) ... ok
test_03_blackbox_exporter (__main__.TestMonitoringPrometheus.test_03_blackbox_exporter) ... ok
test_04_blackbox_exporter_with_config (__main__.TestMonitoringPrometheus.test_04_blackbox_exporter_with_config) ... ok

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Dec 24, 2024

👍
No issues in PR Title / Commit Title

@nvollmar nvollmar force-pushed the T6949 branch 2 times, most recently from 14395ba to 9aa9553 Compare December 24, 2024 21:13
@nvollmar nvollmar marked this pull request as draft December 24, 2024 21:46
@nvollmar nvollmar force-pushed the T6949 branch 7 times, most recently from 22133a8 to eef3a85 Compare December 25, 2024 11:28
@nvollmar nvollmar marked this pull request as ready for review December 26, 2024 11:16
@nvollmar nvollmar force-pushed the T6949 branch 4 times, most recently from d23407e to b444bbc Compare December 26, 2024 15:19
@nvollmar nvollmar force-pushed the T6949 branch 2 times, most recently from fbc98d5 to 90e98d2 Compare December 26, 2024 15:41
@nvollmar nvollmar requested a review from c-po December 26, 2024 16:13
@c-po c-po enabled auto-merge (squash) December 27, 2024 10:56
@nvollmar
Copy link
Contributor Author

The smoke tests won't work until the vyos-build changes are in the image.

@sever-sever
Copy link
Member

Do we need to update debian/control?

auto-merge was automatically disabled December 30, 2024 06:10

Head branch was pushed to by a user without write access

@nvollmar
Copy link
Contributor Author

Do we need to update debian/control?

Aadded

Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@sever-sever sever-sever merged commit 8f0c2c8 into vyos:current Dec 31, 2024
13 of 14 checks passed
@sever-sever
Copy link
Member

Integration failed by not this feature

@nvollmar nvollmar deleted the T6949 branch December 31, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants