T7038: T7039: fix broken RADIUS IPv6 source address and add smoketests #4299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-po
requested review from
dmbaturin,
sarthurdev,
jestabro,
sever-sever,
fett0,
nicolas-fort and
zdc
as code owners
|
👍 |
sever-sever
approved these changes
Jan 10, 2025
c-po
force-pushed
the
radius-smoketest
branch
from
5080575 to
e67853b
Compare
c-po
force-pushed
the
radius-smoketest
branch
from
e67853b to
13d2ad2
Compare
c-po
changed the title
c-po
changed the title
… RADIUS RADIUS is pretty sensible to its configuration. Instead of manual testing, extend the smoketest platform to ship a freeradius container and perform logins against a locally running freeradius server in a container.
When configuring RADIUS to use IPv6 as connection to the server with an
optional source-address
set system login radius server 2001:db8::4 key '9LMVCtPYpG'
set system login radius source-address '2001:db8::1'
It will error out:
pam_radius_auth(sshd:auth): Failed looking up source IP address [2001:db8::1]
for server [2001:db8::4]:1812 (error=System error)
The source address is not allowed to be in [] - thus the brackets need to be
removed.
c-po
force-pushed
the
radius-smoketest
branch
from
f48eb0c to
21b2541
Compare
|
CI integration 👍 passed! Details
|
dmbaturin
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
RADIUS is pretty sensible to its configuration.
Instead of manual testing, extend the smoketest platform to ship a FreeRADIUS container and perform logins against a locally running FreeRADIUS server in a container.
When configuring RADIUS to use IPv6 as connection to the server with an optional source-address:
It will error out:
pam_radius_auth(sshd:auth): Failed looking up source IP address [2001:db8::1] for server [2001:db8::4]:1812 (error=System error)The source address is not allowed to be in [] - thus the brackets need to be removed.
Types of changes
Related Task(s)
Related PR(s)
How to test / Smoketest result
Checklist: