Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T7046: add wrappers for reference tree utilities #4306

Merged
merged 3 commits into from
Jan 21, 2025
Merged

T7046: add wrappers for reference tree utilities #4306

merged 3 commits into from
Jan 21, 2025

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Jan 16, 2025 •
edited
Loading

Change summary

Add wrappers for reference tree utilities. Adjust location of reference tree cache directory.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

DEBUG - OK
DEBUG - vyos@vyos:~$ echo EXITCODE:$^V?
DEBUG - echo EXITCODE:$?
DEBUG - EXITCODE:0
INFO - Smoketest finished successfully!

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Jan 16, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

👍
No issues in PR Title / Commit Title

@jestabro jestabro force-pushed the modular-reference-tree branch from f2b0251 to dc4a1a1 Compare January 20, 2025 21:25
@jestabro
T7046: adjust for distinct reference_tree cache directory
dd5f9c1 
To simplify updating in case of supplemental interface-definitions from
addons, the reftree cache(s) are moved to an independent directory.
@jestabro jestabro force-pushed the modular-reference-tree branch from dc4a1a1 to dd5f9c1 Compare January 21, 2025 01:26
@jestabro jestabro marked this pull request as ready for review January 21, 2025 02:07
@dmbaturin dmbaturin merged commit 24e37c5 into vyos:current Jan 21, 2025
16 checks passed
@github-actions GitHub Actions
Copy link

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin dmbaturin approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever is a code owner

@c-po c-po Awaiting requested review from c-po c-po is a code owner

@fett0 fett0 Awaiting requested review from fett0 fett0 is a code owner

@nicolas-fort nicolas-fort Awaiting requested review from nicolas-fort nicolas-fort is a code owner

@zdc zdc Awaiting requested review from zdc zdc is a code owner

Assignees

@jestabro jestabro

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jestabro @dmbaturin