Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6342: add parsing of docs element #32

Merged
merged 2 commits into from
Jan 14, 2025
Merged

T6342: add parsing of docs element #32

merged 2 commits into from
Jan 14, 2025

Conversation

rebortg
Copy link
Member

@rebortg rebortg commented Jan 8, 2025

Change Summary

Add support to parse <docs> elements from xml

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Other (please describe):

Related Task(s)

Related PR(s)

vyos/vyos-1x#4292

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@rebortg rebortg marked this pull request as ready for review January 9, 2025 13:22
@jestabro jestabro self-requested a review January 10, 2025 02:06
src/reference_tree.ml Outdated Show resolved Hide resolved
src/reference_tree.ml Show resolved Hide resolved
src/reference_tree.mli Show resolved Hide resolved
@jestabro
Copy link
Contributor

Looks good, Robert; suggestions above. Also, you may want to check for trailing whitespace on several lines.

@jestabro jestabro self-requested a review January 13, 2025 13:52
Copy link
Contributor

@jestabro jestabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall; suggestions above.

@rebortg
Copy link
Member Author

rebortg commented Jan 13, 2025

@jestabro i resolve your suggestion

@jestabro jestabro requested a review from dmbaturin January 14, 2025 02:16
@dmbaturin dmbaturin merged commit c4e441a into vyos:current Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants