Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore[ci]: bump upload-artifact action to v4 #4445

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Jan 11, 2025

What I did

Fix #4441.

How I did it

How to verify it

Commit message

chore[ci]: bump upload-artifact action to v4

This commit bumps the upload-artifact action to v4 because
v3 will be deprecated on 30 Jan 2025.

Description for the changelog

Bump upload-artifact action to v4

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.16%. Comparing base (9db1546) to head (5b93c81).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4445      +/-   ##
==========================================
- Coverage   91.96%   91.16%   -0.81%     
==========================================
  Files         119      119              
  Lines       16686    16686              
  Branches     2808     2808              
==========================================
- Hits        15346    15212     -134     
- Misses        921     1029     +108     
- Partials      419      445      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tserg
Copy link
Collaborator Author

tserg commented Jan 11, 2025

How can I test this?

# TODO: this needs to be tested when upgrading to upload-artifact v4
working-directory: artifacts/artifact
run: |
set -Eeuxo pipefail
for BIN_NAME in $(ls)
do
curl -L \
--no-progress-meter \
-X POST \
-H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}"\
-H "Content-Type: application/octet-stream" \
"https://uploads.github.com/repos/${{ github.repository }}/releases/${{ github.event.release.id }}/assets?name=${BIN_NAME/+/%2B}" \
--data-binary "@${BIN_NAME}"
done

@charles-cooper
Copy link
Member

How can I test this?

# TODO: this needs to be tested when upgrading to upload-artifact v4
working-directory: artifacts/artifact
run: |
set -Eeuxo pipefail
for BIN_NAME in $(ls)
do
curl -L \
--no-progress-meter \
-X POST \
-H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}"\
-H "Content-Type: application/octet-stream" \
"https://uploads.github.com/repos/${{ github.repository }}/releases/${{ github.event.release.id }}/assets?name=${BIN_NAME/+/%2B}" \
--data-binary "@${BIN_NAME}"
done

check the build artifacts actions -- ex. https://github.com/vyperlang/vyper/actions/runs/12720146923/job/35461412257?pr=4445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore[ci]: github artifact actions to be deprecated on jan 30
2 participants