Fix finding a similiar html tag

vysokeskoly · Nov 29, 2023 · 48f5fdf · 48f5fdf
1 parent 7123b9f
commit 48f5fdf
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 <!-- There is always Unreleased section on the top. Subsections (Added, Changed, Fixed, Removed) should be added as needed. -->
 ## Unreleased
+- Fix finding a similar html tag
 
 ## 7.4.0 - 2023-10-25
 - Encode html entities in `HtmlHelper` to prevent parse errors

diff --git a/src/Service/HtmlHelper.php b/src/Service/HtmlHelper.php
@@ -94,7 +94,7 @@ public function findAllImages(string $content): array
     private function findAllTags(string $tag, string $requiredAttr, string $content, callable $createTag): array
     {
         $mappedContent = str_replace("\n", self::EOL_PLACEHOLDER, $content);
-        preg_match_all(sprintf('/<%s(.*?)>/', $tag), $mappedContent, $matches);
+        preg_match_all(sprintf('/<%s( .*?)>/', $tag), $mappedContent, $matches);
 
         return $this->mapMatches(
             $this->mapEoLPlaceholders(array_pop($matches)),

diff --git a/tests/Service/HtmlHelperTest.php b/tests/Service/HtmlHelperTest.php
@@ -201,6 +201,10 @@ public function linksProvider(): array
                 '<div>content</div>',
                 [],
             ],
+            'with similar tag' => [
+                '<div><address>content</address></div>',
+                [],
+            ],
             'with one link' => [
                 '<div>content<a href="$$slovnik:prezencni-studium$$"></a></div>',
                 [