[scroll-animations-1] Add examples #11421
Conversation
|
I believe this PR is ready for review. One thing I struggled with is there to place the examples for If I were an author, I would like to see the examples that use As a result, though, the section itself might need some rewording / extra sentences which I can tackle later. |
That should not hold up merging this PR however |
There was a problem hiding this comment.
Some minor comments. General comment is, the goal of example text is to step away from the spec's precision and generality and help the reader see concretely what it does, using the example as an illustration of what the spec means in more practical and illustrative terms.
scroll-animations-1/Overview.bs
Outdated
| In the following example each child of the `.scroller` element | ||
| reveals itself as it enters the scrollport instead of when entirely crossing it. |
There was a problem hiding this comment.
I feel like this needs a bit more explanation to illustrate the point.
There was a problem hiding this comment.
I added the clarification of what view() does to the example that introduced it (at around line 750). .
Co-authored-by: fantasai <fantasai.bugs@inkedblade.net>
Co-authored-by: fantasai <fantasai.bugs@inkedblade.net>
Co-authored-by: fantasai <fantasai.bugs@inkedblade.net>
Co-authored-by: fantasai <fantasai.bugs@inkedblade.net>
…instances per match
|
Addressed the comments. Re-requesting a review. |
Add some examples to the scroll-animations-1 spec.