Reword self-asserted VC in VP text to remove MUST. #1580
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigBlueHat
requested review from
msporny,
TallTed,
iherman,
selfissued and
decentralgabe
as code owners
The original statement was found to be untestable. This new text provides explanatory text instead.
BigBlueHat
force-pushed
the
fix-self-asserted-text
branch
from
f3694a9 to
ae6c07b
Compare
dlongley
approved these changes
Jan 13, 2025
PatStLouis
approved these changes
Jan 13, 2025
msporny
added
CR2
normative
msporny
approved these changes
Jan 13, 2025
TallTed
reviewed
Jan 13, 2025
David-Chadwick
approved these changes
Jan 13, 2025
iherman
approved these changes
Jan 14, 2025
Thanks @TallTed! Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
selfissued
approved these changes
Jan 14, 2025
brentzundel
approved these changes
Jan 14, 2025
msporny
added
editorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original statement was found to be untestable. This new text provides explanatory text instead.
NOTE: the goal of this change is to avoid this text being "at risk" while keeping the intention of the text.
@jandrieu I believe this was originally your text, so please let us know if you're OK with this change.
Thanks!
🎩
Preview | Diff