Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement browsingContext.locateNodes #547
Implement browsingContext.locateNodes #547
Changes from 7 commits
c7d9020
70815c5
3273c1a
841dd88
02b475d
a44d832
8d736ff
d12c49e
5f86c3e
65e042a
de398fa
91343e5
1103af6
f9ad500
141d1be
e35f766
598d1de
bd6084c
f6e4a16
2eca140
3dea404
91caa7f
4d05a1d
652eee3
52216b4
d26d4b0
2587025
f6e6478
bdfc7ba
44f19fd
6da2cd8
7bf6647
fc0bb31
70d5c2e
a76f33f
12e122c
151ea70
dae6599
8497c21
c00d75d
870a0b1
4faf371
19e293e
4dc30da
122a7a1
e4605d1
96d5079
fa10dbc
43752bf
9d3f6f1
8f7d9c0
552f203
98cc9f2
8988a1d
b97e723
165b4fc
b137ed2
9f57155
873a9e7
227da04
f0eda02
efefd38
3568ca4
2eaa2b4
b3a2e59
29a0314
5516d01
b66e363
3d5b847
aba2f66
35f6a88
3c3eefd
d0bb5e1
13586ab
a3cea57
297a11f
5572041
99837f4
c6f041e
c8b7516
be123be
0d77682
c14f010
1d68171
fe2c9fc
ae9938d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It definitely seems like we could support returning non-Element nodes here. Maybe even non-nodes if we can select them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgraham We can support returning non-element nodes, and I'll update the PR to reflect that. However, I would like to retain the restriction to only return nodes from XPath, since the command is
locateNodes
.