Support user contexts #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsnedders
reviewed
Oct 11, 2023
jyasskin
reviewed
Oct 11, 2023
OrKoN
force-pushed
the
orkon/partitions
branch
from
2568aed to
19d010e
Compare
jgraham
reviewed
Oct 30, 2023
OrKoN
force-pushed
the
orkon/partitions
branch
3 times, most recently
from
78bd343 to
9eb17f0
Compare
Merged
OrKoN
force-pushed
the
orkon/partitions
branch
2 times, most recently
from
dd1533d to
a1240f9
Compare
OrKoN
force-pushed
the
orkon/partitions
branch
2 times, most recently
from
2df3c2e to
13b5804
Compare
jugglinmike
reviewed
Nov 8, 2023
OrKoN
commented
Nov 22, 2023
OrKoN
commented
Nov 22, 2023
OrKoN
commented
Nov 22, 2023
OrKoN
force-pushed
the
orkon/partitions
branch
3 times, most recently
from
a7d6f50 to
57acfff
Compare
OrKoN
commented
Dec 8, 2023
index.bs
Outdated
|
|
||
| User contexts other than the [=default user context=] have a <dfn>user context | ||
| id</dfn>, which is a string set upon context creation. The [=default user | ||
| context=]'s does not have a [=user context id=]. |
There was a problem hiding this comment.
I think it might be easier to treat the default context id as undefined.
OrKoN
force-pushed
the
orkon/partitions
branch
from
e303f6b to
e384195
Compare
This gives us an explicit set of top-level user contexts to work with, and makes the association between nagigables and user contexts clearer.
This returns a list of all user contexts. At the moment it doesn't contain any information about the browsing contexts in each user context (so you'd have to cross-reference with browsingContext.getTree).
jgraham
requested changes
Jan 18, 2024
whimboo
reviewed
Jan 19, 2024
jgraham
reviewed
Jan 19, 2024
jgraham
approved these changes
Jan 19, 2024
juliandescottes
approved these changes
Jan 19, 2024
github-actions bot
added a commit
that referenced
this pull request
Jan 22, 2024
SHA: 55adba6 Reason: push, by OrKoN Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User Contexts allow basic isolation of the web content state and parallelization of test runs without paying the costs of launching a fresh/multiple browser processes. In this proposal, there is no session created for the user context: multiple user contexts are managed by the same session. The advantage is that the same session can create a fresh state for its operations. In practical terms, we want to have something that would allow us to implement https://pptr.dev/api/puppeteer.browsercontext/#example In Chrome, that corresponds to an incognito window (but you can have multiple for automation).
Issue #289
Related links:
Open questions/TODOs:
Preview | Diff