Serialize entire browsing context tree for contextDestroyed events #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple navigables / contexts are destroyed at once we only emit a single event. To ensure that that the client gets information about every context that's destroyed, send the whole context tree in that event, rather than just the topmost context.
lutien
approved these changes
Oct 24, 2023
I believe this only takes effect if it's in the first comment. At least, a tooltip only shows up for it when it is in the first comment. |
OrKoN
approved these changes
Oct 24, 2023
thiagowfx
approved these changes
Oct 24, 2023
|
@lutien would you mind to update the tests while implementing it on our side? We have https://bugzilla.mozilla.org/show_bug.cgi?id=1860955 for it. |
whimboo
added
enhancement
github-actions bot
added a commit
that referenced
this pull request
Oct 25, 2023
) SHA: 38ba606 Reason: push, by whimboo Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple navigables / contexts are destroyed at once we only emit a single event. To ensure that that the client gets information about every context that's destroyed, send the whole context tree in that event, rather than just the topmost context.
Closes #573
Preview | Diff