Always include stacktrace for console messages #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
approved these changes
Jan 14, 2025
| 1. If |method| is "<code>assert</code>", "<code>error</code>", | ||
| "<code>trace</code>", or "<code>warn</code>", let |stack| be the [=current | ||
| stack trace=]. Otherwise let |stack| be null. | ||
| 1. Let |stack| be the [=current stack trace=]. |
There was a problem hiding this comment.
With this change stack can't be null so we can simplify the next step:
the
stackTracefield set to |stack| if |stack| is not null, or
omitted otherwise,
can become
the
stackTracefield set to |stack|
Also I think stackTrace is now mandatory in log.BaseLogEntry?
There was a problem hiding this comment.
I guess GenericLogEntry can still be without stack? (it does not seem to be used but maybe reserved for other kinds of entries?)
There was a problem hiding this comment.
Ah yes indeed. A bit weird to have an unused / undefined log type here, but that's another topic :)
Thanks for the patch and sorry about the delay
juliandescottes
requested changes
Jan 14, 2025
OrKoN
force-pushed
the
orkon/stacktrace-always
branch
from
fcf1d86 to
e6001f1
Compare
juliandescottes
approved these changes
Jan 14, 2025
This was referenced Jan 14, 2025
github-actions bot
added a commit
that referenced
this pull request
Jan 15, 2025
SHA: c6bc3f2 Reason: push, by OrKoN Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
OrKoN
added a commit
that referenced
this pull request
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alternative to #807 it makes sense to always include the stacktrace so that the client can figure out where the logs are coming from.
Preview | Diff