Support preload scripts per user context #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/preload-user-context
branch
2 times, most recently
from
1f64732 to
5b3ea11
Compare
OrKoN
force-pushed
the
orkon/preload-user-context
branch
from
5b3ea11 to
712afd0
Compare
2 tasks
juliandescottes
requested changes
Jan 17, 2025
Co-authored-by: Julian Descottes <jdescottes@mozilla.com>
Co-authored-by: Julian Descottes <jdescottes@mozilla.com>
OrKoN
commented
Jan 17, 2025
jgraham
reviewed
Jan 17, 2025
juliandescottes
approved these changes
Jan 17, 2025
OrKoN
force-pushed
the
orkon/preload-user-context
branch
from
5ea2f50 to
f8311a9
Compare
Comment on lines
+9815
to
+9821
| 1. Set |user contexts| to [=set/create|create a set=] with |command parameters|["<code>userContexts</code>"]. | ||
|
|
||
| 1. For each |user context id| of |user contexts|: | ||
|
|
||
| 1. Set |user context| to [=get user context=] with |user context id|. | ||
|
|
||
| 1. If |user context| is null, return [=error=] with [=error code=] [=no such user context=]. |
There was a problem hiding this comment.
nit: maybe iterate through the |command parameters|["<code>userContexts</code>"], assert valid values and append them to existing map |user contexts| to increase readability and align with contexts logic one step above?
sadym-chromium
approved these changes
Jan 17, 2025
jgraham
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #849
Preview | Diff