-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add use case 3 for custom NACK/RTX #59
Draft
pthatcher
wants to merge
3
commits into
main
Choose a base branch
from
peter/use-case-3-custom-rtx
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
# Custom RTX Use Case | ||
|
||
## Motivation | ||
|
||
Advanced web applications wish to control NACK and RTX behavior, such as being able to control how large the RTX packet cache is, or how long packets stay in the cache. | ||
|
||
## Examples | ||
|
||
### Example: Custom RTX packet cache | ||
|
||
```javascript | ||
const [pc, rtpTransport, rtpSender] = setupPeerConnectionWithRtpTransport(); // Custom | ||
const rtxPacketCache = createRtxPacketCache(); // Custom | ||
const rtpSendStream = await rtpSender.replaceSendStreams()[0]; | ||
rtpSendStream.onpacketizedrtp = () => { | ||
const rtpPackets = rtpSendStream.readPacketizedRtp(); | ||
for (const rtpPacket of rtpPackets) { | ||
rtxPacketCache.cacheRtpPacket(rtpPacket); | ||
rtpSendStream.sendRtp(rtpPacket); | ||
} | ||
}; | ||
// TODO: How do we disable normal NACK processing? | ||
rtpSendStream.onreceivedrtcpnacks = () => { | ||
const nacks = rtpSendStream.readReceivedRtcpNacks(); | ||
for (const nack of nacks) { | ||
for (const seqnum of nack.sequenceNumbers) { | ||
const cachedRtpPacket = rtxPacketCache.getCachedRtpPacketBySequenceNumber(seqnum); | ||
if (cachedRtpPacket) { | ||
rtpSendStream.sendRtp(cachedRtpPacket, {asRtx: true}); | ||
} | ||
} | ||
} | ||
} | ||
``` | ||
|
||
### Example: Custom NACK | ||
|
||
```javascript | ||
const [pc, rtpTransport, rtpReceiver] = setupPeerConnectionWithRtpTransport(); // Custom | ||
const nackCalculator = createNackCalculator(); // Custom | ||
const rtpReceiveStream = await rtpReceiver.replaceReceiveStreams()[0]; | ||
// TODO: How do we disable normal NACK sending? | ||
rtpReceiveStream.onrtpreceived = () => { | ||
const rtpPacket = rtpReceiveStream.readReceivedRtp(); | ||
const nackedSequenceNumbers = nackCalaculator.calculateNackedSequenceNumbers(rtpPacket); | ||
if (nackedSequenceNumbers) { | ||
rtpRecieveStream.sendNack(nackedSequenceNumbers); | ||
} | ||
} | ||
``` | ||
|
||
### Example: Custom RTX payload | ||
|
||
TODO |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Advanced web applications wish to control NACK and RTX behavior
It's not not true, but it's also not very accurate IMO. We want to be able to use custom NACK and RTX mechanisms and formats, not just the standardized ones.
This version of the UC3 also does not support something like FlexFEC.