Bring Your Own Packets #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henbos
commented
Jan 14, 2025
| attribute octet payloadType; | ||
| attribute unsigned short sequenceNumber; | ||
| attribute unsigned long timestamp; | ||
| attribute unsigned long ssrc; | ||
| sequence<unsigned long> getCsrcs(); |
There was a problem hiding this comment.
Sequences are copied by value and cannot be attributes, but I think we could use ObservableArray<T> to avoid the array copies as well then nothing is a copy (you would still internally need to copy between JS layer and C++ layer in read and write methods but we would not have any temporary objects imposted on the user of the API IIUC)
|
Another option is if we can move more towards dictionaries, because I'm told native JS objects are more optimized for temporaries than C++ wrapped objects, but that would probably require forcing the app to use BYOB for reading (not just writing) in order to avoid the copyPayloadTo() methods since dictionaries can't have methods and interfaces are slower to GC supposedly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77.
Allows constructing and modifying RTCRtpPacket such that packets can be read or written without having to construct temporary objects for every packet that goes through the pipeline which could be several thousands/s (easily > 10K/s).
Because you can both read and write to packets in order to recycle them between read and write calls, the the RTCRtpPacket attributes are no longer read-only. The sequence<T> members are still getters because of WebIDL rules but setter methods are added.
The payload is no longer an internal detail, it's an attribute, allowing it to be modified or replaced as well.
copyPayloadTois no longer needed because you can copy withset(packet.payload)To be discussed:
Preview | Diff