Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracts tool Evaluation #932

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Contracts tool Evaluation #932

merged 3 commits into from
Jul 27, 2023

Conversation

Ali-Usama
Copy link
Contributor

@Ali-Usama Ali-Usama commented Jul 21, 2023

External Evaluation

  • The milestone delivery is as per the application and no critical issues are found in the delivery. A detailed evaluation is attached here.

Link to the application pull request: w3f/Grants-Program#1750

@Whisker17
Copy link
Contributor

Whisker17 commented Jul 21, 2023

Hey @Bug-Whisperer I just noticed that you submitted an external evaluation of contracts-tool(seems you haven't finished yet), which I was likewise very interested in, and submitted my evaluation here. I'm not quite sure how such a conflict should be resolved so I'll leave it to the evaluators' judgment, so if you have any thoughts on this please do let me know, thanks very much.

@dsm-w3f dsm-w3f self-assigned this Jul 24, 2023
@dsm-w3f
Copy link
Contributor

dsm-w3f commented Jul 25, 2023

@Ali-Usama thank you for the external evaluation. I'll not merge it yet since we had two external evaluations for this milestone delivery. This is something new for us. We will discuss internally how to handle this case and circle back to you soon.

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Jul 27, 2023

@Ali-Usama we discussed internally and in this case we will accept both evaluations. However, our guidelines will be updated soon to include that external evaluators open a draft PR as soon as they start to work to avoid duplicate evaluations. I'll forward your KSM payment. Great job!

@dsm-w3f dsm-w3f merged commit d4005f9 into w3f:master Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants