Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add grant management webapp 2 application #1967

Closed

Conversation

lawmeskiviahs
Copy link
Contributor

@lawmeskiviahs lawmeskiviahs commented Sep 13, 2023

Grant Management Webapp 2

This application is a follow-up for Grant Management Webapp. This grant is for completing the development of gmw.
I am adding this as a draft PR because there are some requirements that we need to discuss before getting the actual proposal in. The things I want to discuss are:

1. Treasury pallet integration

  • We have made a POC for treasure pallet integration. We would like to ask you more about how to proceed with this.

2. Github Actions:

  • The application stores and displays all the important data related to the grants. As for the application and delivery PRs, data is parsed from the MD files and saved into our DB.
  • Would you like us to integrate Github Actions (comment, approve, reject, merge) within the GMW or do you want the webapp to show the important data and then redirect links to github when an action is needed?

3. General Design and Feature discussion:

  • We would like the committee to look into the designs and features and tell us if they would like to add anything.

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines.
  • Payment details have been provided (bank details via email or BTC, Ethereum (USDC/DAI) or Polkadot/Kusama (USDT) address in the application).
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
  • I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Sep 18, 2023

@lawmeskiviahs is this as a draft PR for some reason? Let us know when we could evaluate it since the PR is not actually open.

@lawmeskiviahs
Copy link
Contributor Author

Hi @dsm-w3f we have started the work on the default deliverables (the applications and deliverables pages). There are some discussion points that I have added to the first comment of this PR. It would be great to have some clarity about the treasury pallet and GitHub Actions integration. I was going to open this PR after we have a discussion on these points.

@lawmeskiviahs lawmeskiviahs force-pushed the grants_management_milestone_2 branch from 7322877 to a7d3406 Compare September 19, 2023 06:21
@lawmeskiviahs lawmeskiviahs marked this pull request as ready for review September 19, 2023 06:26
@dsm-w3f dsm-w3f self-assigned this Sep 19, 2023
@dsm-w3f
Copy link
Contributor

dsm-w3f commented Sep 19, 2023

@lawmeskiviahs thank you for the grant application. What do you mean by integration with treasure pallet? As far as I know, grants and treasure are completely separate, with different people and processes working on them. It would be nice to focus on grants first since we could evaluate if it is appropriate for the task. I evaluated the first version of the Grant Management webapp (GMA), and one concern is that it does not sync with GitHub data after the first load of data. Now, I understand that you want to perform that with GitHub actions, is that right? If we plan to use this app, it could be first as a backup of GitHub, since it is our main software now. Would be possible to run GMA in parallel with GitHub with a reliable sync mechanism? I mean, GitHub actions sometimes fail, if it fails, how to get the data synced with GitHub again?

@lawmeskiviahs
Copy link
Contributor Author

Hi @dsm-w3f thankyou for your time

  • Treasury Pallet Integration:
    The mention of the Treasury Pallet integration in the RFP sparked our interest, and we've conducted preliminary research on this. We'd like to understand the committee's perspective on this integration. Integrating the Treasury Pallet can potentially offer significant advantages in terms of financial management and disbursement within the grant management web application. We look forward to discussing this further to align our development plans with the committee's vision.
  • GitHub Webhooks:
    After the initial syncing with GitHub, we have successfully integrated webhooks with the grant management web app. This integration ensures that the application stays synchronized with any new content or changes made to GitHub repositories. We've tested this feature by integrating test repositories into the application to guarantee its reliability and effectiveness. Please follow this link to read more about GitHub Webhooks.
  • GitHub Actions(comment, approve, request changes, merge, close etc):
    I'm sorry for creating this confusion, by Github Actions I meant comment, approve, request changes, merge and close for Pull Requests. We've explored the possibility of leveraging GitHub Actions into our application as to make it the primary platform for managing actions related to the grant management web application. By integrating GitHub actions into our application, we believe it can become your one-stop solution. This integration would streamline workflows, reducing the number of clicks and steps required to perform essential tasks. We'd appreciate your thoughts on this approach as it could enhance the user experience and efficiency for the committee.

@lawmeskiviahs
Copy link
Contributor Author

Pinging @dsm-w3f

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Sep 25, 2023

@lawmeskiviahs thank you for the answer. I still think that Treasury Pallet Integration could be handled later since the main purpose of this app is to be useful for managing grants and trying to deliver software to handle grants and treasury together could be challenging. My suggestion is to remove it from the scope of this application.

What do you mean by "After the initial syncing with GitHub, we have successfully integrated webhooks with the grant management web app. "? This is already developed? I evaluated the previous grant from you and don't remember to have this functionality.

I don't see in the application document functionality to sync the GitHub data and the GWA. I think this feature is essential for us to do more comprehensive testing of the GWA since we don't plan to use it as our main system at least for now. This could enable us to try it in parallel with Github. Could you please add this feature to your application if this is not already implemented?

@lawmeskiviahs lawmeskiviahs force-pushed the grants_management_milestone_2 branch 2 times, most recently from d367f08 to e43c021 Compare September 26, 2023 05:31
@lawmeskiviahs
Copy link
Contributor Author

@dsm-w3f thankyou for your reply. I understand about the treasury pallet and I'll remove it from the application.

We already started the implementation of github webhooks in the previous milestone. We made a separate controller for handling github related functionalities. The webhook implementation is written within this controller. Follow this link to find the said controller. For more information on how github webhooks work follow this link.

We understand the importance of real-time data in the grants management webapp. The webhooks facilitate this real-time data scenario for us. This has been mentioned in the application.

@lawmeskiviahs
Copy link
Contributor Author

pinging @dsm-w3f

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Sep 28, 2023

@lawmeskiviahs thank you for the answer. I'll make the application ready to review. The committee will probably add more questions and opinions soon.

@dsm-w3f dsm-w3f added the ready for review The project is ready to be reviewed by the committee members. label Sep 28, 2023
@lawmeskiviahs
Copy link
Contributor Author

Thankyou @dsm-w3f

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the application. I have one initial question here: What are your future plans for the project? I personally would also be more interested in your other application: #2007

@lawmeskiviahs lawmeskiviahs force-pushed the grants_management_milestone_2 branch from e43c021 to 28cfc35 Compare October 3, 2023 12:24
@lawmeskiviahs lawmeskiviahs requested a review from Noc2 October 3, 2023 12:24
@lawmeskiviahs
Copy link
Contributor Author

Thankyou @Noc2 for your time, I have added the future plans to this application document. I have also updated the other application as well. Looking forward to hearing from you.

@lawmeskiviahs
Copy link
Contributor Author

pinging @Noc2

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Oct 11, 2023

@lawmeskiviahs thank you for the grant application. Unfortunately, the committee decided not to go forward with it. We have doubts about the utility and if we would be able to use the application. I wish you the best of luck in the next applications.

@dsm-w3f dsm-w3f closed this Oct 11, 2023
@lawmeskiviahs
Copy link
Contributor Author

Thankyou @dsm-w3f for the update. I appreciate your indulging with us in our journey of making the ecosystem better and more effective.
The Grant Management Webapp has served as an entry for us into the core system. It is a pilot project that helped us with getting familiarised with the Grants Ecosystem. I personally feel that this initiative is the best way to explore what has already been done, projects that are currently being developed, leaving us with insights about what can be achieved in the future. We have been moving deeper into the Substrate Ecosystem with our work and appreciate the Grant Team's support.

We combined the problems that we thought needed utmost attention into the first milestone of the GMW. The two main things were storing all the data and extracting only the relevant data. Extraction of data was particularly tricky as the format provided by the team was not properly followed. We utilised the time to effectively solve these two problems mainly in the first milestone.

Developing functionality over the data was envisioned as a part of the second milestone. We have better understanding of the system and more of the relevant data that we need after the first milestone. Keeping this in mind, we have started working on enhancements to the experience, utility and security of the application in the milestone 2. We envision the application to be a one-stop-shop for the Grants Program. We have tried to accommodate everything that is needed into the update of the application. We thin it is essential to make the Grants Program seamless and hassle free. The main idea behind the application was to reduce the number of clicks and have all the required information readily available when needed.

In case of any other queries I am here for help. Thankyou for your assistance throughout our journey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants