-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Burve Protocol W3F Grant Application #2343
Conversation
CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. Please submit the following text as a separate comment: I have read and hereby sign the Contributor License Agreement. You can retrigger this bot by commenting recheck in this Pull Request |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | - | Generic High Entropy Secret | 0d3bb35 | applications/BurveProtocol | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Thanks for the application @WenSwen199a
|
Hey @WenSwen199a , |
Fix markdown
pinging @WenSwen199a |
- Milestone 2 markdown table format fixed - Milestone 1 audit deliverable deleted
Thank you @keeganquigley @PieWol @semuelle !
|
pinging @WenSwen199a Also, please remember to sign the CLA. |
|
||
### Project Details | ||
#### UI | ||
Our MVP is based on Solidity and is already live, and the Polkadot version will be developed based on the Substrate tech stack and Polkadot structure with the same UI. [Check UI here](https://app.burve.io/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the plans for smart contracts on AssetHub it will be possible to compile your Solidity code to PolkaVM so that you can simply port your project to Polkadot. See the roadmap here. Have you considered waiting for that moment? Given that Parity plans to achieve this until EOY it sounds like a wasted effort to me to now rewrite your whole tech to work on substrate. This way you could also conveniently integrate with all the assets already living on AssetHub so that you suffer no liquidity fragmentation which you raised as a concern yourself earlier in the application. Furthermore given that this transition towards enabling smart contracts on AssetHub will be iterative and starting on the testnet Westend, you could align your project with this strategy and do an experimental deployment on Westend or Kusama so that you can validate your project instead of having to deploy to Polkadot directly. What do you think?
Hey @WenSwen199a , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm closing the application due to inactivity. Let me know if I should re-open it.
Project Abstract
Grant level
Application Checklist
project_name.md
).@kari19says:matrix.org
(change the homeserver if you use a different one)