Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scope of Milestone 1 #2346

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Update scope of Milestone 1 #2346

merged 2 commits into from
Jul 23, 2024

Conversation

singkeo
Copy link
Contributor

@singkeo singkeo commented Jul 18, 2024

Hello,

I've already written by e-mail that it would take us longer than expected.

We additionally developed a Rust-based client that allows the user to log into their Gmail account, receive a JWT, paste the JWT into the client CLI, generate an ephemeral public/private keypair, generate a ZK proof using the JWT, public key and salt as inputs and send it to the collator by calling the appropriate extrinsic. Note that the outputs of the client serve as inputs to the extrinsic calls.

Unfortunately we didn't find any Polkadot SDK-compatible library that is capable of verifying the jwt signatures against the OAuth2 Authorization Server (the instance that signs the JWT). We've tried using JWT compact, RSA, Ring but none of them worked, so we decided to implement it on the client instead. Obviousely, we can't assume that the client is trustworthy, however, we see this as the first step of a possible offchain-worker-based signature validation, since std libraries are supported there. Overall, the requirements changed during the process of developing and we realized, we need to build the client first, otherwise it'd be too difficult to implement the on-chain part.

Project Abstract

Please replace these instructions with a brief description of your project summarising key points (1-2 paragraphs).

If your application is a follow-up to a previous grant, please mention which one in the first line of the abstract and include a link to previous pull requests if applicable.

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines.
  • Payment details have been provided (Polkadot AssetHub (DOT, USDC & USDT) address in the application and bank details via email, if applicable).
  • I understand that an agreed upon percentage of each milestone will be paid in vested DOT, to the Polkadot address listed in the application.
  • I am aware that, in order to receive a grant, I (and the entity I represent) have to successfully complete a KYC/KYB check.
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
  • I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

@github-actions github-actions bot added the admin-review This application requires a review from an admin. label Jul 18, 2024
@keeganquigley keeganquigley added amendment This PR proposes changes to an existing application. and removed admin-review This application requires a review from an admin. labels Jul 18, 2024
keeganquigley
keeganquigley previously approved these changes Jul 18, 2024
Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @singkeo thanks for the amendment. Could you please also include the application PR in the post? #2175

Additionally, since it is taking longer than expected could you also update the timeline? That way you can add an additional month or two to take the pressure off. Thanks.

@keeganquigley keeganquigley self-requested a review July 18, 2024 16:50
@keeganquigley keeganquigley added the changes requested The team needs to clarify a few things first. label Jul 18, 2024
@keeganquigley keeganquigley dismissed their stale review July 18, 2024 16:51

accidental approval

@github-actions github-actions bot added the admin-review This application requires a review from an admin. label Jul 22, 2024
@keeganquigley keeganquigley removed the admin-review This application requires a review from an admin. label Jul 22, 2024
Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @singkeo LGTM

@keeganquigley keeganquigley added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Jul 22, 2024
@takahser takahser merged commit 7db412c into w3f:master Jul 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amendment This PR proposes changes to an existing application. ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants