-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scope of Milestone 1 #2346
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
admin-review
This application requires a review from an admin.
label
Jul 18, 2024
keeganquigley
added
amendment
This PR proposes changes to an existing application.
and removed
admin-review
This application requires a review from an admin.
labels
Jul 18, 2024
keeganquigley
previously approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keeganquigley
added
the
changes requested
The team needs to clarify a few things first.
label
Jul 18, 2024
5 tasks
github-actions
bot
added
the
admin-review
This application requires a review from an admin.
label
Jul 22, 2024
keeganquigley
removed
the
admin-review
This application requires a review from an admin.
label
Jul 22, 2024
keeganquigley
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @singkeo LGTM
keeganquigley
added
ready for review
The project is ready to be reviewed by the committee members.
and removed
changes requested
The team needs to clarify a few things first.
labels
Jul 22, 2024
Noc2
approved these changes
Jul 23, 2024
takahser
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
amendment
This PR proposes changes to an existing application.
ready for review
The project is ready to be reviewed by the committee members.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've already written by e-mail that it would take us longer than expected.
We additionally developed a Rust-based client that allows the user to log into their Gmail account, receive a JWT, paste the JWT into the client CLI, generate an ephemeral public/private keypair, generate a ZK proof using the JWT, public key and salt as inputs and send it to the collator by calling the appropriate extrinsic. Note that the outputs of the client serve as inputs to the extrinsic calls.
Unfortunately we didn't find any Polkadot SDK-compatible library that is capable of verifying the jwt signatures against the OAuth2 Authorization Server (the instance that signs the JWT). We've tried using JWT compact, RSA, Ring but none of them worked, so we decided to implement it on the client instead. Obviousely, we can't assume that the client is trustworthy, however, we see this as the first step of a possible offchain-worker-based signature validation, since std libraries are supported there. Overall, the requirements changed during the process of developing and we realized, we need to build the client first, otherwise it'd be too difficult to implement the on-chain part.
Project Abstract
Grant level
Application Checklist
project_name.md
).@_______:matrix.org
(change the homeserver if you use a different one)