Fixed code smell

w3stling · Aug 8, 2022 · e5142f7 · e5142f7
1 parent eb7b804
commit e5142f7
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/src/main/java/com/apptasticsoftware/insynsregistret/Transaction.java b/src/main/java/com/apptasticsoftware/insynsregistret/Transaction.java
@@ -607,7 +607,7 @@ else if ("Konvertibel".equals(instrumentType) || "Convertible".equals(instrument
             else if ("Obligation".equals(instrumentType) || "Bond".equals(instrumentType) || "InstrumentTyp7".equals(instrumentType)) {
                 type = BOND;
             }
-            else if ("Option".equals(instrumentType) || "Option".equals(instrumentType) || "InstrumentTyp8".equals(instrumentType)) {
+            else if ("Option".equals(instrumentType) || "InstrumentTyp8".equals(instrumentType)) {
                 type = OPTION;
             }
             else if ("Teckningsoption".equals(instrumentType) || "Subscription warrant".equals(instrumentType) || "InstrumentTyp11".equals(instrumentType)) {
@@ -619,7 +619,7 @@ else if ("Teckningsrätt/Uniträtt".equals(instrumentType) || "Subscription righ
             else if ("Terminer".equals(instrumentType) || "Future/Forward".equals(instrumentType) || "InstrumentTyp13".equals(instrumentType)) {
                 type = FUTURE_FORWARD;
             }
-            else if ("Warrant".equals(instrumentType) || "Warrant".equals(instrumentType) || "InstrumentTyp14".equals(instrumentType)) {
+            else if ("Warrant".equals(instrumentType) || "InstrumentTyp14".equals(instrumentType)) {
                 type = WARRANT;
             }
             else if ("Övriga derivatkontrakt".equals(instrumentType) || "Other derivative contracts".equals(instrumentType) || "InstrumentTyp15".equals(instrumentType)) {

diff --git a/src/test/java/com/apptasticsoftware/insynsregistret/FreeTextQueryTest.java b/src/test/java/com/apptasticsoftware/insynsregistret/FreeTextQueryTest.java
@@ -84,14 +84,14 @@ void getIssuer_EmptyString() throws IOException {
     }
 
     @Test
-    public void getIssuer_null() {
+    void getIssuer_null() {
         assertThrows(IllegalArgumentException.class, () ->
                 FreeTextQueryBuilder.issuer(null).build());
     }
 
 
     @Test
-    public void getPDMR_Jo() throws IOException {
+    void getPDMR_Jo() throws IOException {
         FreeTextQuery query = FreeTextQueryBuilder.pdmr("Jo").build();
 
         Insynsregistret ir = new Insynsregistret();
@@ -101,20 +101,20 @@ public void getPDMR_Jo() throws IOException {
 
 
     @Test
-    public void getPDMR_null() {
+    void getPDMR_null() {
         assertThrows(IllegalArgumentException.class, () ->
             FreeTextQueryBuilder.pdmr(null).build());
     }
 
 
     @Test
-    public void freeTestQueryNullParams() throws IOException {
+    void freeTestQueryNullParams() throws IOException {
         FreeTextQuery query = new FreeTextQuery(null, null);
         assertEquals("", query.getUrl());
     }
 
     @Test
-    public void badResponse() throws IOException {
+    void badResponse() throws IOException {
         BufferedReader reader = new BufferedReader(new StringReader("[\"Test1\",\"Test2\",\"Test3]"));
 
         Insynsregistret mock = spy(Insynsregistret.class);
@@ -126,7 +126,7 @@ public void badResponse() throws IOException {
     }
 
     @Test
-    public void emptyResponse() throws IOException {
+    void emptyResponse() throws IOException {
         BufferedReader reader = new BufferedReader(new StringReader("[]"));
 
         Insynsregistret mock = spy(Insynsregistret.class);

diff --git a/src/test/java/com/apptasticsoftware/insynsregistret/TransactionQueryTest.java b/src/test/java/com/apptasticsoftware/insynsregistret/TransactionQueryTest.java
@@ -60,7 +60,7 @@ void badTransactionFromDate() {
         LocalDate to = LocalDate.of(2018, 3,1);
 
         assertThrows(IllegalArgumentException.class, () ->
-                TransactionQueryBuilder.transactions(from, to).build());
+                TransactionQueryBuilder.transactions(from, to));
     }
 
     @Test
@@ -75,7 +75,7 @@ void badTransactionToDate() {
     @Test
     void badTransactionPastDays() {
         assertThrows(IllegalArgumentException.class, () ->
-                TransactionQueryBuilder.transactionsLastDays(-1).build());
+                TransactionQueryBuilder.transactionsLastDays(-1));
     }