Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type conversion #628

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Improve type conversion #628

merged 3 commits into from
Jan 27, 2025

Conversation

waybackarchiver
Copy link
Contributor

@waybackarchiver waybackarchiver commented Jan 1, 2025

Description

Improve type conversion

Checklist

  • I have followed the contributing guidelines
  • I have reviewed and understood the Code of Conduct
  • I have searched and make sure there's no duplicate PRs
  • I have updated the changelog in case of need

@waybackarchiver waybackarchiver added enhancement New feature or request go Pull requests that update Go code labels Jan 1, 2025
@waybackarchiver waybackarchiver changed the title Fix type conversion Improve type conversion Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 11.53846% with 23 lines in your changes missing coverage. Please review.

Project coverage is 45.05%. Comparing base (3505bdc) to head (375b945).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
service/discord/discord.go 0.00% 7 Missing ⚠️
service/telegram/telegram.go 0.00% 7 Missing ⚠️
service/utils.go 0.00% 6 Missing ⚠️
config/options.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
+ Coverage   44.56%   45.05%   +0.49%     
==========================================
  Files          84       86       +2     
  Lines        6815     6942     +127     
==========================================
+ Hits         3037     3128      +91     
- Misses       3484     3513      +29     
- Partials      294      301       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waybackarchiver waybackarchiver merged commit 58e581c into main Jan 27, 2025
92 checks passed
@waybackarchiver waybackarchiver deleted the fix-type-conversion branch January 27, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant