Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

강의실 예약 제한 #312

Merged
merged 1 commit into from
Aug 19, 2024
Merged

강의실 예약 제한 #312

merged 1 commit into from
Aug 19, 2024

Conversation

leeeryboy
Copy link
Contributor

강의실 예약 제한

한줄 요약

행정실 요청: 공과대학 강의실 예약 제한 반영

@leeeryboy leeeryboy requested a review from huGgW August 19, 2024 03:49
@leeeryboy leeeryboy self-assigned this Aug 19, 2024
Copy link
Collaborator

@huGgW huGgW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ㅋㅋㅋ...

Copy link

Test Results

12 files  12 suites   1s ⏱️
59 tests 59 ✔️ 0 💤 0
66 runs  66 ✔️ 0 💤 0

Results for commit 5d6b903.

@leeeryboy leeeryboy merged commit fa8b7f9 into develop Aug 19, 2024
3 checks passed
@leeeryboy leeeryboy deleted the fix/reservation-lecture branch August 19, 2024 03:53
leeeryboy added a commit that referenced this pull request Aug 19, 2024
* 교과목 정렬, 쿠키 secure 옵션 추가 (#308)

* feat: 교과목 정렬

* feat: 쿠키 secure 옵션 추가

* referrer policy 헤더 추가 (#311)

* referrer policy 헤더 추가

* 헤더 수정

* feat: scholarship CRUD (#309)

* feat: scholarship CRUD

* 불필요한 라인 삭제

* 리뷰 반영

* Update deploy_dev.yaml

* 강의실 예약 제한 (#312)
@huGgW huGgW mentioned this pull request Sep 23, 2024
leeeryboy added a commit that referenced this pull request Sep 23, 2024
* 교과목 정렬, 쿠키 secure 옵션 추가 (#308)

* feat: 교과목 정렬

* feat: 쿠키 secure 옵션 추가

* referrer policy 헤더 추가 (#311)

* referrer policy 헤더 추가

* 헤더 수정

* feat: scholarship CRUD (#309)

* feat: scholarship CRUD

* 불필요한 라인 삭제

* 리뷰 반영

* Update deploy_dev.yaml

* 강의실 예약 제한 (#312)

* feat: 소개 탭 CRUD (#314)

* feat: 소개 탭 CRUD

* fix: 권한 체크 추가

* fix: 동아리 id 기준으로 로직 변경

* fix: 쿠키 same-site: strict

* 리뷰 반영

* 리뷰 반영

* 로그인 핫픽스 (#316)

* Feat: Research Group & Center 언어포함 CRUD 생성 (#315)

* refactor: deprecated v1 controller

* refactor: extract types in seperate package, remove unused attachment from research

* feat: make lab's research as nullable

* feat: add research language entity & repository

* feat: add language & sealed dtos

* feat: remove migrate methods & seperate update index methods

* feat: add CRUD language considered methods

* feat: add v2 reserach controller

* fix: fix test compiling

* test: fix professerservice test

* refactor: fix ktlint formatting

* review: research -> fetch lazy

* Refactor: 구성원 POST API image => mainImage 리펙토링 #317

* Refactor: PUT API newImage => newMainImage 수정 #318

* Feat: Lab CRUD (#319)

* feat: add request body

* feat: modify dto nullability

* feat: extract lab service && implement CRUD

* feat: add lab language dto

* feat: add lab events

* fix: fix unique constraints for research language entity

* feat: add methods to repositories

* feat: add LAB CRUD APIs

* refactor: seperate event services

* refactor: professors to mutable var

* fix: fix typos

* comment: add comment to professor service method

* test: remove unneed test file

* feat: split search service and event service

* feat: implement professor, research event service

* fix: apply ktlint

* cascade 제거 (#321)

* cascade 제거

* 이미지 제거 추가

---------

Co-authored-by: Junhyeong Kim <leeeryboy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants