Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

선호 학과 정보 저장 #323

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

chaemin2001
Copy link
Contributor

일단 이렇게 구현해봤습니당 ..

@chaemin2001 chaemin2001 requested a review from a team as a code owner January 1, 2025 12:20
SNUTT-2022/SNUTT/Views/Components/FilterSheetContent.swift Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경사항이 없어서 line에 직접 못적는데 좌측 태그 카테고리쪽 UI 변경사항도 같이 반영해주세용

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그리고 필터 내부 스크롤이 안되는데(실기기&시뮬레이터 둘다 iOS 18.0+) 혹시 재현돼?
시뮬레이터 iOS 17.2에서는 문제 없는거같긴해

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xcode 16 + ios 18 에서 highPriorityGesture 문제 있는듯..
snutt 2024에서는 고쳐놨는데 ㅋㅋ..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅇㅋ 색상이랑 폰트 크기 이런거 말하는거 맞지?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엉 그거랑 내부 스크롤 안되는 문제도..!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스크롤 문제는

func sheetGesture(_ translation: Binding<CGFloat>, dismiss: @escaping @MainActor () -> Void) -> some View {
if #available(iOS 18.0, *) {
gesture(SheetGestureRecognizer(translation: translation, dismiss: dismiss))
} else {
highPriorityGesture(DragGesture().onChanged({ value in
translation.wrappedValue = value.translation.width
}).onEnded({ value in
translation.wrappedValue = 0
if value.velocity.width < -300 || value.translation.width < -100 {
dismiss()
}
}))

여기 참고하면 될듯!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

참고해서 고쳤는데 이게 위로 스크롤 시에 sheet가 dismiss되는 문제가 있는데 .. 실기기에서도 똑같겠지 ..?ㅜㅜ

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하. 이거는 bottom sheet구나. 그러면 저 코드에서 value.velocity.width 랑 translation.width 를 height로 바꿔야할듯! x는 y로 바꾸고.

let departmentTags = tagList.filter { tag in tag.type == .department &&
!appState.search.pinnedTagList.contains { $0.text == tag.text }
}
var updatedTags = appState.search.pinnedTagList + departmentTags
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스펙상 가장 최근에 선택한 학과가 최상단에 노출되어야하는데 지금은 맨 뒤에 붙는 듯..!

@peng-u-0807 peng-u-0807 force-pushed the chaemin2001/pin-recent-searched-departments branch from d72e44c to 41ddcbc Compare January 14, 2025 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants