NIMTP-2909 Parse PER Administrative Communications Contact #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 694f2cd.
|
|
lkolla447
reviewed
Dec 11, 2024
| // PER03/05/07, Code identifying the type of communication number | ||
| private String communicationNumberQualifier; | ||
|
|
||
| // PER04/06/08, Complete communications number including country or area code when applicable |
There was a problem hiding this comment.
It can be telephone number or email, can we change these to communicationDetailQualifier and communicationDetail or communicationInfoQualifier and communicationInfo
There was a problem hiding this comment.
I got this name communicationNumberQualifier/communicationNumber from 856 Ship Notice/Manifest pdf..
| @@ -17,6 +17,7 @@ N4*ATLANTA*GA*31139-0020**SN*9999 | |||
| N1*SF*1 EDI SOURCE | |||
| N3*31875 SOLON ROAD | |||
| N4*SOLON*OH*44139 | |||
| PER*PY*FSMA CONTACT*TE*+18884636332*EA*FoodSafetyPlanBuilder@fda.hhs.gov | |||
There was a problem hiding this comment.
Can you add a test case with PER segment at the item level with UR qualifier?
dilip7069
reviewed
Dec 16, 2024
| @@ -650,6 +688,8 @@ private List<X12Segment> getTransactionSetSegments() { | |||
| txSegments.add(new X12Segment("HL*12*11*I")); | |||
| txSegments.add(new X12Segment("LIN**UP*039364133147")); | |||
| txSegments.add(new X12Segment("SN1**2*EA")); | |||
| txSegments.add(new X12Segment("N1*SF*RESER'S FINE FOODS, INC.*UL*0090266420001")); | |||
There was a problem hiding this comment.
At item level N101 should be MP or ZW
dilip7069
approved these changes
Dec 16, 2024
lkolla447
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.