CR feedback - Griffin

wandb · Jan 21, 2025 · 8e5fca1 · 8e5fca1
1 parent 23d1504
commit 8e5fca1
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 23 deletions.
diff --git a/weave-js/src/components/PagePanelComponents/Home/Browse3/grid/pagination.ts b/weave-js/src/components/PagePanelComponents/Home/Browse3/grid/pagination.ts
@@ -1,7 +1,7 @@
 import {GridPaginationModel} from '@mui/x-data-grid-pro';
 
 const MAX_PAGE_SIZE = 100;
-export const DEFAULT_PAGE_SIZE = 100;
+export const DEFAULT_PAGE_SIZE = 50;
 
 export const getValidPaginationModel = (
   queryPage: string | undefined,

diff --git a/weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallPage/CallDetails.tsx b/weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallPage/CallDetails.tsx
@@ -189,6 +189,7 @@ export const CallDetails: FC<{
               entity={call.entity}
               project={call.project}
               allowedColumnPatterns={ALLOWED_COLUMN_PATTERNS}
+              paginationModel={isPeeking ? {page: 0, pageSize: 10} : undefined}
             />
           );
           if (isPeeking) {

diff --git a/weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallsPage/CallsTable.tsx b/weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallsPage/CallsTable.tsx
@@ -948,6 +948,7 @@ export const CallsTable: FC<{
         rowSelectionModel={rowSelectionModel}
         // columnGroupingModel={groupingModel}
         columnGroupingModel={columns.colGroupingModel}
+        hideFooter={!callsLoading && callsTotal === 0}
         hideFooterSelectedRowCount
         onColumnWidthChange={newCol => {
           setUserDefinedColumnWidths(curr => {
@@ -1021,7 +1022,7 @@ export const CallsTable: FC<{
             );
           },
           columnMenu: CallsCustomColumnMenu,
-          pagination: PaginationButtons,
+          pagination: () => <PaginationButtons hideControls={hideControls} />,
           columnMenuSortDescendingIcon: IconSortDescending,
           columnMenuSortAscendingIcon: IconSortAscending,
           columnMenuHideIcon: IconNotVisible,

diff --git a/...-js/src/components/PagePanelComponents/Home/Browse3/pages/CallsPage/CallsTableButtons.tsx b/...-js/src/components/PagePanelComponents/Home/Browse3/pages/CallsPage/CallsTableButtons.tsx
@@ -648,7 +648,11 @@ type PageSizeOption = {
   readonly label: string;
 };
 
-export const PaginationButtons = () => {
+type PaginationButtonsProps = {
+  hideControls?: boolean;
+};
+
+export const PaginationButtons = ({hideControls}: PaginationButtonsProps) => {
   const apiRef = useGridApiContext();
   const page = useGridSelector(apiRef, gridPageSelector);
   const pageCount = useGridSelector(apiRef, gridPageCountSelector);
@@ -719,25 +723,29 @@ export const PaginationButtons = () => {
           icon="chevron-next"
         />
       </Box>
-      <Box
-        sx={{
-          fontSize: '14px',
-          fontWeight: '400',
-          color: MOON_500,
-          display: 'flex',
-          alignItems: 'center',
-          gap: '8px',
-        }}>
-        Per page:
-        <Select<PageSizeOption>
-          size="small"
-          menuPlacement="top"
-          options={pageSizeOptions}
-          value={pageSizeValue}
-          isSearchable={false}
-          onChange={onPageSizeChange}
-        />
-      </Box>
+      {hideControls ? null : (
+        <Box
+          sx={{
+            fontSize: '14px',
+            fontWeight: '400',
+            color: MOON_500,
+            display: 'flex',
+            alignItems: 'center',
+            gap: '8px',
+            // Regrettable hack to appear over Material scrollbar's z-index of 6.
+            zIndex: 7,
+          }}>
+          Per page:
+          <Select<PageSizeOption>
+            size="small"
+            menuPlacement="top"
+            options={pageSizeOptions}
+            value={pageSizeValue}
+            isSearchable={false}
+            onChange={onPageSizeChange}
+          />
+        </Box>
+      )}
     </Box>
   );
 };
diff --git a/...-js/src/components/PagePanelComponents/Home/Browse3/views/Leaderboard/LeaderboardGrid.tsx b/...-js/src/components/PagePanelComponents/Home/Browse3/views/Leaderboard/LeaderboardGrid.tsx
@@ -400,7 +400,7 @@ export const LeaderboardGrid: React.FC<LeaderboardGridProps> = ({
           },
         }}
         slots={{
-          pagination: PaginationButtons,
+          pagination: () => <PaginationButtons />,
         }}
       />
     </Box>
-Original file line number
+Diff line change
@@ Expand Up @@
               },
             }}
             slots={{
-              pagination: PaginationButtons,
+              pagination: () => <PaginationButtons />,
             }}
           />
         </Box>
@@ Expand Down @@