Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): Playground settings / show more / trials area #3311

Merged
merged 14 commits into from
Jan 21, 2025

Conversation

m-rgba
Copy link
Contributor

@m-rgba m-rgba commented Dec 24, 2024

Description

  • Updated trials view to be re-sizable (added re-sizable component which can be used for alternative drawers).
  • Tweaked trial header buttons / added sticky header.
  • Updated Show More buttons to be smaller and fixed old overlay issues to have them sit on top (updated the backgrounds to make them a little less visually weighted as well).
  • Fixed issue with MessagePanel and tool calls having show more + max-height.

@circle-job-mirror
Copy link

@m-rgba
Copy link
Contributor Author

m-rgba commented Dec 30, 2024

@m-rgba m-rgba marked this pull request as ready for review December 30, 2024 15:54
@m-rgba m-rgba requested review from a team as code owners December 30, 2024 15:54
Copy link
Contributor

@jwlee64 jwlee64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, except a small fix necessary

Screen.Recording.2025-01-02.at.8.11.37.AM.mov

I think the show more is resizing in the drawer incorrectly.
The show more is only showing the last like 20 pixels regardless of the height of the content.

@m-rgba
Copy link
Contributor Author

m-rgba commented Jan 2, 2025

Lgtm, except a small fix necessary

Screen.Recording.2025-01-02.at.8.11.37.AM.mov
I think the show more is resizing in the drawer incorrectly. The show more is only showing the last like 20 pixels regardless of the height of the content.

Will fix - interesting, yeah it only looks like that's in the trials, in the regular chat views it seems to be the right height
Example via: https://beta.wandb.ai/wandb-designers/winston/weave/playground/0193f98a-540c-71f2-a794-d24dcab2af3c
image
image

@m-rgba
Copy link
Contributor Author

m-rgba commented Jan 21, 2025

@m-rgba m-rgba requested a review from jwlee64 January 21, 2025 22:40
Copy link
Contributor

@jwlee64 jwlee64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, new change looks good, did we want to hide the message panel buttons in the choices view?

@jwlee64
Copy link
Contributor

jwlee64 commented Jan 21, 2025

wait nvm all g

@m-rgba m-rgba enabled auto-merge (squash) January 21, 2025 22:53
@m-rgba m-rgba merged commit 902bdaf into master Jan 21, 2025
126 of 128 checks passed
@m-rgba m-rgba deleted the playground-settings-trials branch January 21, 2025 23:08
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants