Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(weave): Document autopatch_settings for PII nb #3317

Merged
merged 13 commits into from
Jan 8, 2025
Merged

docs(weave): Document autopatch_settings for PII nb #3317

merged 13 commits into from
Jan 8, 2025

Conversation

J2-D2-3PO
Copy link
Contributor

@J2-D2-3PO J2-D2-3PO commented Jan 3, 2025 •
edited
Loading

https://wandb.atlassian.net/browse/DOCS-1150

@J2-D2-3PO J2-D2-3PO self-assigned this Jan 3, 2025
@circle-job-mirror
Copy link

circle-job-mirror bot commented Jan 3, 2025 •
edited
Loading

Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=a1e6d841a5d3b175dabbd89d6ff9c014feb23bad

@J2-D2-3PO J2-D2-3PO changed the title docs(weave): Document autopatch_settings for PII nb and general settings docs(weave): Document autopatch_settings for PII nb Jan 6, 2025
@J2-D2-3PO J2-D2-3PO requested a review from andrewtruong January 7, 2025 00:31
@J2-D2-3PO J2-D2-3PO marked this pull request as ready for review January 7, 2025 00:32
@J2-D2-3PO J2-D2-3PO requested a review from a team as a code owner January 7, 2025 00:32
@J2-D2-3PO J2-D2-3PO requested a review from andrewtruong January 7, 2025 17:48
@J2-D2-3PO J2-D2-3PO requested a review from a team January 7, 2025 19:31
andrewtruong
andrewtruong reviewed Jan 8, 2025
View reviewed changes
docs/docs/reference/gen_notebooks/pii.md


```python
%%capture
# @title required python packages:
!pip install cryptography
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already listed below

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same issue in the nb

andrewtruong
andrewtruong approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@andrewtruong andrewtruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm :)

@J2-D2-3PO
Copy link
Contributor Author

I'm now getting the rate limit failure for Notify wandb/core / notify-wandb-core (push) and Check PR / Validate PR title (pull_request_target) I was getting on (unrelated) #3342 just now. Any thoughts @andrewtruong ? Is this just for my GH user or is this a quota limit for GH checks run on this repo?

Error: API rate limit exceeded for user ID 93349595. If you reach out to GitHub Support for help, please include the request ID 4401:1AEC1C:AB2AAC:15456EF:677DE4C8 and timestamp 2025-01-08 02:36:56 UTC.
``

@J2-D2-3PO J2-D2-3PO merged commit 3bdbbbc into master Jan 8, 2025
121 checks passed
@J2-D2-3PO J2-D2-3PO deleted the DOCS-1150 branch January 8, 2025 19:46
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewtruong andrewtruong andrewtruong approved these changes

Assignees

@J2-D2-3PO J2-D2-3PO

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@J2-D2-3PO @andrewtruong