feat(weave): Allow Dataset to be constructed from Calls #3382
+120
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=a883b76529b75e01aa4b851c912f7f02f7d1c3f5 |
tssweeney
reviewed
Jan 15, 2025
weave/trace/weave_client.py
Outdated
| @@ -534,6 +534,13 @@ class ApplyScorerSuccess: | |||
| wc._send_score_call(self, score_call, scorer_ref_uri) | |||
| return apply_scorer_result | |||
|
|
|||
| def to_dict(self) -> dict: | |||
There was a problem hiding this comment.
I would more concretely type this so that the dict coming out has strongly typed fields
tssweeney
reviewed
Jan 16, 2025
weave/trace/weave_client.py
Outdated
| d["op_name"] = self.op_name | ||
| d["display_name"] = self.display_name | ||
|
|
||
| return cast(CallDict, d) |
There was a problem hiding this comment.
this cast is not guaranteed. I would do something to at least validate the keys
There was a problem hiding this comment.
What case do you see missing here?
andrewtruong
force-pushed
the
andrew/dataset-call
branch
from
58a9c22 to
69f7b89
Compare
tssweeney
reviewed
Jan 22, 2025
| @@ -54,6 +55,11 @@ def from_obj(cls, obj: WeaveObject) -> Self: | |||
| rows=obj.rows, | |||
| ) | |||
|
|
|||
| @classmethod | |||
| def from_calls(cls, calls: Iterable[Call]) -> Self: | |||
| rows = [call.to_dict() for call in calls] | |||
There was a problem hiding this comment.
so much network traffic here. Hopefully in the future we can do something serverside
tssweeney
approved these changes
Jan 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://wandb.atlassian.net/browse/WB-22700