Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(weave_query): propgate tags on mapped run ops during gql key propagation #3386

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

domphan-wandb
Copy link
Contributor

@domphan-wandb domphan-wandb commented Jan 13, 2025

Description

Fixes WB-21889

Bug description

runs.loggedArtifactVersions causes a panel crash for users with the error:
No ops found for "tag-run" with first arg "TaggedValueType({['project', 'indexCheckpoint']}, artifactVersionType({'id': 'String()'}))"

The tag-run op expects an input type that's tagged with the run, but the tag is missing during compilation.

Solution

I added logic to handle propagating tags onto mapped run ops because the existing logic (should_tag_op_def_outputs) will only create a TaggedValueType if the opdef's input is a ProjectType or a singular RunType. In the case of mapped run ops, the inputs will always be a List of RunTypes. This specifically happens in run ops that are gql_connection_op.

Other mapped run ops have tags properly propagated because they go through the refinement codepath during compilation.

Testing

  • I tested this through the UI in my dev environment
Screen.Recording.2025-01-13.at.7.57.01.AM.mov
  • Previously, the runs.loggedArtifactVersions would cause a panel crash

@domphan-wandb domphan-wandb requested a review from a team as a code owner January 13, 2025 15:59
@circle-job-mirror
Copy link

@domphan-wandb domphan-wandb force-pushed the dom/fix-run-loggedArtifactVersions branch from 859bb9a to aa11e11 Compare January 22, 2025 15:37
@domphan-wandb domphan-wandb merged commit a2fe0e5 into master Jan 22, 2025
128 checks passed
@domphan-wandb domphan-wandb deleted the dom/fix-run-loggedArtifactVersions branch January 22, 2025 17:06
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants