Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): dont do the cost query if no calls found #3469

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

gtarpenning
Copy link
Member

@gtarpenning gtarpenning commented Jan 22, 2025

Description

WB-22886

Micro perf improvement by not querying for costs when we have no calls to display.

in prod we actually query for costs twice even when there are no calls.

Testing

Prod:
Screenshot 2025-01-22 at 1 57 10 PM

Branch:
Screenshot 2025-01-22 at 1 57 42 PM

@gtarpenning gtarpenning marked this pull request as ready for review January 22, 2025 22:02
@gtarpenning gtarpenning requested review from a team as code owners January 22, 2025 22:02
@gtarpenning gtarpenning requested a review from jwlee64 January 22, 2025 22:03
Copy link
Contributor

@jwlee64 jwlee64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niceee

@gtarpenning gtarpenning enabled auto-merge (squash) January 22, 2025 22:04
@circle-job-mirror
Copy link

@gtarpenning gtarpenning merged commit 84cb396 into master Jan 22, 2025
126 of 128 checks passed
@gtarpenning gtarpenning deleted the griffin/dont-do-cost-query-if-no-results branch January 22, 2025 22:08
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants