Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): remove expandColumns with get_calls #3471

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

gtarpenning
Copy link
Member

Description

Fix for frontend export code gen. Fixes 2 cases:

  • no need for expandColumns (sdk resolves refs)
  • when selected calls, extra }

Testing

Screenshot 2025-01-22 at 3 53 19 PM

@gtarpenning gtarpenning marked this pull request as ready for review January 22, 2025 23:54
@gtarpenning gtarpenning requested review from a team as code owners January 22, 2025 23:54
@gtarpenning gtarpenning requested a review from jwlee64 January 22, 2025 23:55
Copy link
Contributor

@jwlee64 jwlee64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@gtarpenning gtarpenning enabled auto-merge (squash) January 22, 2025 23:58
@circle-job-mirror
Copy link

circle-job-mirror bot commented Jan 23, 2025

@gtarpenning gtarpenning merged commit 56024bf into master Jan 23, 2025
125 of 127 checks passed
@gtarpenning gtarpenning deleted the griffin/fix-export-with-expand-columns branch January 23, 2025 00:06
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants