use local var println formatting

cli/CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Unreleased
 
 - remove dependency on nohash-hasher.
+- use local var println formatting.
 
 <a name="v0.5.3"></a>
 

cli/src/chip.rs

@@ -104,7 +104,7 @@ impl CmdResults {
             );
         }
         for e in &self.errors {
-            eprintln!("{}", e);
+            eprintln!("{e}");
         }
     }
 }

cli/src/common.rs

@@ -172,10 +172,10 @@ pub fn emit_error(opts: &EmitOpts, e: &anyhow::Error) {
     let e_str = format_error(opts, e);
     #[cfg(feature = "json")]
     if opts.json {
-        println!("{{\"error\":\"{}\"}}", e_str);
+        println!("{{\"error\":\"{e_str}\"}}");
         return;
     }
-    eprintln!("{}", e_str);
+    eprintln!("{e_str}");
 }
 
 pub fn format_error(opts: &EmitOpts, e: &anyhow::Error) -> String {

cli/src/main.rs

@@ -34,7 +34,7 @@ fn main() -> ExitCode {
                 ExitCode::FAILURE
             };
         }
-        Err(e) => eprintln!("{}", e),
+        Err(e) => eprintln!("{e}"),
     }
     ExitCode::FAILURE
 }

cli/src/notify.rs

@@ -248,7 +248,7 @@ impl CmdResults {
             return;
         }
         for e in &self.errors {
-            eprintln!("{}", e);
+            eprintln!("{e}");
         }
     }
 
@@ -328,9 +328,9 @@ impl Event {
                 print!("{} {} ", ci.name, self.change.info.offset);
             }
             if opts.emit.quoted {
-                println!("\"{}\"", lname);
+                println!("\"{lname}\"");
             } else {
-                println!("{}", lname);
+                println!("{lname}");
             }
         } else {
             println!("{} {}", ci.name, self.change.info.offset);

cli/src/platform.rs

@@ -70,7 +70,7 @@ impl Platform {
     fn print(&self) {
         println!("Kernel {}", self.kernel.version);
         for e in &self.errors {
-            eprintln!("{}", e);
+            eprintln!("{e}");
         }
         for abi in &self.abis {
             match abi.unsupported_by {
@@ -82,7 +82,7 @@ impl Platform {
                     println!("Kernel supports all {} features.", abi.version);
                 }
                 for f in &abi.missing_features {
-                    println!("Kernel version does not support {}", f);
+                    println!("Kernel version does not support {f}");
                 }
             }
         }

cli/src/set.rs

@@ -284,15 +284,15 @@ impl Setter {
         loop {
             match self.parse_command(&mut clcmd, &rl.readline()?) {
                 Ok(am) => {
-                    if let Err(err) = self.do_command(am, opts) {
-                        println!("{}", err);
+                    if let Err(e) = self.do_command(am, opts) {
+                        println!("{e}");
                         // clean in case the error leaves dirty lines.
                         self.clean();
                         return Ok(true);
                     }
                 }
-                Err(err) => {
-                    println!("{}", err);
+                Err(e) => {
+                    println!("{e}");
                 }
             }
         }

lib/CHANGELOG.md

@@ -4,6 +4,8 @@
 
 - remove dependency on `nohash-hasher`.
 - move adding attributes to v2::LineConfig to uapi.
+- use local var println formatting.
+
 
 <a name="v0.7.0"></a>
 

lib/examples/async_io_watch_line_value.rs

@@ -22,7 +22,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
     );
     async_io::block_on(async {
         while let Ok(event) = req.read_edge_event().await {
-            println!("{:?}", event);
+            println!("{event:?}");
         }
     });
     Ok(())

lib/examples/async_std_watch_line_value.rs

@@ -23,7 +23,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
     );
     async_std::task::block_on(async {
         while let Ok(event) = req.read_edge_event().await {
-            println!("{:?}", event);
+            println!("{event:?}");
         }
     });
     Ok(())

lib/examples/find_line_by_name.rs

@@ -9,12 +9,11 @@ fn main() {
     match gpiocdev::find_named_line(line_name) {
         Some(gpio22) => {
             println!(
-                "{}: {} {}",
-                line_name,
+                "{line_name}: {} {}",
                 gpio22.chip.file_name().unwrap().to_string_lossy(),
                 gpio22.info.offset
             )
         }
-        None => println!("line {} not found", line_name),
+        None => println!("line {line_name} not found"),
     }
 }

lib/examples/get_line_info.rs

@@ -11,6 +11,6 @@ fn main() -> gpiocdev::Result<()> {
 
     let chip = gpiocdev::chip::Chip::from_path(chip_path)?;
     let info = chip.line_info(offset)?;
-    println!("{:?}", info);
+    println!("{info:?}");
     Ok(())
 }

lib/examples/get_line_value.rs

@@ -20,7 +20,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
         .request()?;
 
     let value = req.value(offset)?;
-    println!("{}={:?}", offset, value);
+    println!("{offset}={value}");
 
     Ok(())
 }

lib/examples/get_multiple_line_values.rs

@@ -20,11 +20,11 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
     // get all requested line values at once
     let mut values = Values::default();
     req.values(&mut values)?;
-    println!("all values = {:?}", values);
+    println!("all values = {values:?}");
 
     // or individually
     let mut values = Values::from_offsets(&[23]);
     req.values(&mut values)?;
-    println!("one value = {:?}", values);
+    println!("one value = {values:?}");
     Ok(())
 }

lib/examples/pulse_multiple_line_values.rs

@@ -7,7 +7,6 @@
 use gpiocdev::line::{Value, Values};
 use gpiocdev::Request;
 use std::result::Result;
-use std::thread;
 use std::time::Duration;
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
@@ -20,7 +19,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
         .request()?;
 
     // some time later...
-    thread::sleep(Duration::from_secs(2));
+    std::thread::sleep(Duration::from_secs(2));
 
     // change the values at once...
     let mut values = Values::default();

lib/examples/toggle_line_value.rs

@@ -8,7 +8,6 @@ use anyhow::Context;
 use gpiocdev::line::Value;
 use gpiocdev::Request;
 use std::result::Result;
-use std::thread;
 use std::time::Duration;
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
@@ -24,8 +23,8 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
         .context("Failed to request line")?;
 
     loop {
-        println!("{}={:?}", offset, value);
-        thread::sleep(Duration::from_millis(500));
+        println!("{offset}={value}");
+        std::thread::sleep(Duration::from_millis(500));
         value = value.not();
         req.set_value(offset, value)
             .context("Failed to set value")?;

lib/examples/toggle_multiple_line_values.rs

@@ -27,7 +27,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
         .context("Failed to request line")?;
 
     loop {
-        println!("{:?}", values);
+        println!("{values:?}");
         thread::sleep(Duration::from_millis(500));
         values.not();
         req.set_values(&values).context("Failed to set values")?;

lib/examples/tokio_ticking_watch_line_value.rs

@@ -26,7 +26,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     loop {
         tokio::select! {
             Some(Ok(event)) = events.next() => {
-                println!("{:?}", event);
+                println!("{event:?}");
             }
             _ = ticker.tick() => {
                 let elapsed_time = now.elapsed();

lib/src/lib.rs

@@ -42,7 +42,7 @@
 //!     .with_debounce_period(std::time::Duration::from_millis(5))
 //!     .request()?;
 //! for edge in req.edge_events() {
-//!     println!("{:?}", edge);
+//!     println!("{edge:?}");
 //! }
 //! # Ok(())
 //! # }