This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
Add metadata from Figma api to Icon search #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
clairehhelms
requested review from
clairehhelms
and removed request for
clairehhelms
wp-aberg
changed the title
There was a problem hiding this comment.
The filtering is awesome! I think for some search terms (like social) it works really well, but for other terms (for example: food, time, heart), the results aren't super helpful/specific, though. Maybe we'd get more specific results if the threshold was lowered a bit? Idk
artmsilva
approved these changes
Jul 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances search by providing metadata pulled from Figma via its API.
The page for all foundations pages conditionally fetches the api data on the icons page and provides it as a static prop that is then passed to the MDXRemote element's
scopeprop. This allows the IconSamples component to use the component data from that scope via a prop.Client side fuzzy searching is handled by Fuse.js from the provided metadata allowing for expanded search terms.
Eg: a search for "social" will return the social icons based on their assigned category description in Figma
Where previously this would have no results
