Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes define checking updated. Example folders created. #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ricklon
Copy link

@ricklon ricklon commented Aug 8, 2016

The defines were updated to check for 3 options and if none were defined to throw an error.

The library doesn't show up in the Arduino IDE because the INO files were no in there own folders. That information is now in place.

I tested the code compiles with the huzzah esp8266 board.

@lucasvinals
Copy link

lucasvinals commented Nov 1, 2016

Hi guys! This is a great library but I'm stuck with this part of definition.

Any progress on this? Even if I add #define ESP8266 at the top of my .ino file, when compiled I have:

error: missing binary operator before token "ENC28J60" #if (!defined(ESP8266) || !defined(W5100) || !defined(ENC28J60)ENC28J60) //If no interface is defined

To get rid of this I manually remove the checking parts and only include the ESP library, but it's a terrible hack..

Thanks.

@washo4evr
Copy link
Owner

the error was here : !defined(ENC28J60)ENC28J60)

I fixed it

Thanks

@lucasvinals
Copy link

Thanks! I'll try this tonight

@hipotenusa
Copy link

Shouldn't it be && instead of || when checking the defined interface? For my understanding it should compile with just one #define according with the hardware. At least I have changed it with && and it now compiles fine.
Thanks for the great library.

@washo4evr
Copy link
Owner

I thought I had fixed it
thanks for the reminder :)

glad you are enjoying this library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants