Close host files when the last FD referencing them is closed #5323
Conversation
…dles when FdList is dropped, add test
…o make them safe again
There was a problem hiding this comment.
I'm quite against abusing the notion of unsafe here to emulate some notion of scoping.
Why don't we do things properly by providing a way to get a borrow to the inner content, while making the public fields private to prevent misuse?
Yes, the file system is not in a great state, but adding a huge hack on top of other hacks is bound to lead to more issues in the future.
Mostly because it'll have rippling effects across the code. The FS code is not very well encapsulated, and adding proper encapsulation requires non-trivial amounts of refactoring. I'm not a huge fan of this either, but I'm trying to minimise the amount of time we spend refactoring code we know has to go as soon as possible. I'll try to see if we can't make a small refactor. |
No description provided.