Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gRPC channel shutdown error #238

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

antas-marcin
Copy link
Collaborator

This PR fixes this error that started occurring in tests:

2023-11-14 13:17:49 5.15.0 SEVERE *~*~*~ Previous channel ManagedChannelImpl{logId=1, target=localhost:32774} was not shutdown properly!!! ~*~*~*
    Make sure to call shutdown()/shutdownNow() and wait until awaitTermination() returns true. 
java.lang.RuntimeException: ManagedChannel allocation site
	at io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference.<init>(ManagedChannelOrphanWrapper.java:102)
	at io.grpc.internal.ManagedChannelOrphanWrapper.<init>(ManagedChannelOrphanWrapper.java:60)
	at io.grpc.internal.ManagedChannelOrphanWrapper.<init>(ManagedChannelOrphanWrapper.java:51)
	at io.grpc.internal.ManagedChannelImplBuilder.build(ManagedChannelImplBuilder.java:655)
	at io.grpc.ForwardingChannelBuilder2.build(ForwardingChannelBuilder2.java:261)
	at io.weaviate.client.base.grpc.GrpcClient.create(GrpcClient.java:30)
	at io.weaviate.client.WeaviateClient.<init>(WeaviateClient.java:46)
	at io.weaviate.client.WeaviateClient.<init>(WeaviateClient.java:33)
	at io.weaviate.integration.client.batch.ClientBatchGrpcCreateTest.createClient(ClientBatchGrpcCreateTest.java:204)
	at io.weaviate.integration.client.batch.ClientBatchGrpcCreateTest.testCreateBatch(ClientBatchGrpcCreateTest.java:172)
	at io.weaviate.integration.client.batch.ClientBatchGrpcCreateTest.shouldCreateBatchUsingGRPC(ClientBatchGrpcCreateTest.java:47)

@antas-marcin antas-marcin force-pushed the grpc-channel-shutdown-fix branch from 95f8d9c to 065285d Compare November 14, 2023 14:52
@antas-marcin antas-marcin merged commit 0bc8bf6 into main Nov 14, 2023
1 check passed
@antas-marcin antas-marcin deleted the grpc-channel-shutdown-fix branch November 14, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants