refactor(lsp): remove useless logging & methods #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crt:weblsp
Princesseuh
commented
Dec 15, 2024
| let _init_params: InitializeParams = serde_json::from_value(init_params).unwrap(); | ||
|
|
||
| for msg in &connection.receiver { | ||
| // TODO: Handle trace levels and notifications instead of just printing them to stderr. | ||
| eprintln!("new msg: {:?}", msg); |
There was a problem hiding this comment.
This log is unnecessary, you can set weblsp.trace.server to either messages or verbose for the client to output what messages you received / sent
Princesseuh
commented
Dec 15, 2024
| // Handle the rest of the messages. | ||
| match msg { | ||
| Message::Request(req) => { | ||
| let request = | ||
| requests::handle_request(req, &mut css_language_service, &connection)?; | ||
| match connection.handle_shutdown(&req) { |
There was a problem hiding this comment.
didn't know this existed when I made the initial shutdown support, turns out this does the same as what I did manually. We still need a global state eventually
CodSpeed Performance ReportMerging #16 will improve performances by ×2.2Comparing Summary
Benchmarks breakdown
|
goulvenclech
approved these changes
Dec 15, 2024
goulvenclech
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Just some small changes, using existing methods instead of new ones, renamed settings etc.
How is it tested?
N/A
How is it documented?
N/A