fix(luhn): empty input should return false

webdeveric · Dec 18, 2024 · e277359 · e277359
1 parent 2026120
commit e277359
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/luhn.ts b/src/luhn.ts
@@ -1,8 +1,8 @@
 export function luhn(input: number | bigint | string): boolean {
   const value = typeof input === 'string' ? input : String(input);
 
-  // input contained non digit characters.
-  if (/[^\d]/.test(value)) {
+  // value is empty or contained non digit characters.
+  if (!value.length || /\D/.test(value)) {
     return false;
   }
 

diff --git a/test/luhn.test.ts b/test/luhn.test.ts
@@ -18,8 +18,8 @@ describe('luhn()', () => {
     expect(luhn(4000000000001001)).toBeFalsy();
   });
 
-  it.each(['not a credit card number', '-1', Number.POSITIVE_INFINITY, Number.NEGATIVE_INFINITY])(
-    'returns false when giving bad input: %s',
+  it.each(['', ' ', 'not a credit card number', '-1', Number.POSITIVE_INFINITY, Number.NEGATIVE_INFINITY])(
+    'returns false when giving bad input: "%s"',
     (input) => {
       expect(luhn(input)).toBeFalsy();
     },