Drawer component demo overhaul #107
Conversation
laurenic0l
commented
Nov 25, 2024
laurenic0l
commented
- demos now reflect best practices
- renamed drawerdemoview.java to drawerview.java
- renamed drawerDemo.css to drawerAutoFocus.css
- reflect best practices - renamed drawerdemoview.java to drawerview.java - renamed drawerDemo.css to drawerAutoFocus.css
src/main/java/com/webforj/samples/views/drawer/DrawerAutoFocusView.java
Outdated
Show resolved
Hide resolved
| @@ -32,85 +25,77 @@ | |||
| @FrameTitle("Drawer Welcome App") | |||
There was a problem hiding this comment.
Revise this demo to align with the style of the demo found here:
There was a problem hiding this comment.
@laurenic0l Use the same image instead in here of the webforj logo
There was a problem hiding this comment.
@laurenic0l For this demo, it should look identical to the one shown here, except for the logo in the sidebar. Also, ensure that the new toolbar component is used.
src/main/java/com/webforj/samples/views/drawer/DrawerWelcomeView.java
Outdated
Show resolved
Hide resolved
- Improved design and layout for the DrawerWelcomeView, including responsive styling and better content alignment. - Updated DrawerPlacementView with vertical radio button placement and functionality to toggle drawer placement dynamically. - All other changes requested to the demos were made
There was a problem hiding this comment.
@laurenic0l I really like the TaskManager idea. It looks great overall. I’ve asked for a few minor adjustments.
src/main/java/com/webforj/samples/views/drawer/DrawerAutoFocusView.java
Outdated
Show resolved
Hide resolved
src/main/java/com/webforj/samples/views/drawer/DrawerAutoFocusView.java
Outdated
Show resolved
Hide resolved
src/main/java/com/webforj/samples/views/drawer/DrawerAutoFocusView.java
Outdated
Show resolved
Hide resolved
- created class fields for getBoundComponent()s - changed divs to flexlayout - when checkbox is clicked the label is striked through in drawerview - moved css to java class keeping only what is needed
|
| demo.setDrawerPlacement(DrawerPlacement.LEFT); | ||
|
|
||
| // Drawer's logo container and logo | ||
| Div drawerLogo = new Div(); |
| @@ -32,85 +25,77 @@ | |||
| @FrameTitle("Drawer Welcome App") | |||
There was a problem hiding this comment.
@laurenic0l For this demo, it should look identical to the one shown here, except for the logo in the sidebar. Also, ensure that the new toolbar component is used.
|
@laurenic0l Please also get these issues fixed |
