Add installRoot to /getConfiguration method #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
throwaway96
force-pushed
the
installRootPath-20231126
branch
from
d4e0cde to
fa8ab48
Compare
kitsuned
reviewed
Dec 6, 2023
throwaway96
force-pushed
the
installRootPath-20231126
branch
2 times, most recently
from
1e4a704 to
a6765af
Compare
Allows callers to determine where Homebrew Channel is installed. This will usually be /media/developer/apps.
throwaway96
force-pushed
the
installRootPath-20231126
branch
from
a6765af to
19bd0a5
Compare
kitsuned
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/getConfigurationLuna method now returns the root path of Homebrew Channel's installation asinstallRoot. Currently this will be/media/developer/appsin the vast majority of cases, but this feature will make it easier to support installation elsewhere in the future.While it looks like there are no significant changes to
path.resolve()between Node.js v0.10.x, v0.12.x, v8.x, v12.x, and the current version, I put it inside atryblock anyway. You never really know with node.Appears to work:
{"returnValue":true,"root":false,"installRoot":"/media/developer/apps","telnetDisabled":true,"failsafe":false,"sshdEnabled":true,"blockUpdates":true}EDIT: Renamed to
homebrewBaseDir.