Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My attempt to fix e.getClass().equals(BeanManager.class), where Strin… #3034

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

dk2k
Copy link
Contributor

@dk2k dk2k commented Aug 19, 2024

…g is compared with Class. However, two parts combined with && looks ridiculous. There is no class, which is subtype of both NameClassPair and BeanManager. Please consider this PR as bug report

…g is compared with Class. However, two parts combined with && looks ridiculous. There is no class, which is subtype of both NameClassPair and BeanManager. Please consider this PR as bug report
@dk2k dk2k requested a review from manovotn as a code owner August 19, 2024 19:01
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this does look like an oversight.

@manovotn manovotn merged commit a790d50 into weld:master Aug 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants