Support Java 7 #81 #94
Conversation
| <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.sortMembersInGroups>true</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.sortMembersInGroups> | ||
| <org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.keepGettersAndSettersTogether>true</org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.keepGettersAndSettersTogether> | ||
| <de-markiewb-netbeans-plugins-eclipse-formatter.preserveBreakPoints>true</de-markiewb-netbeans-plugins-eclipse-formatter.preserveBreakPoints> | ||
| <de-markiewb-netbeans-plugins-eclipse-formatter.eclipseFormatterActiveProfile/> |
There was a problem hiding this comment.
I don't think that these entries de-markiewb-netbeans-plugins-eclipse-formatter are needed, are they?
There was a problem hiding this comment.
Die Zeilen waren bereits vorher drin. Nur irgendwie hat mein NB die Lineendings geaendert. Mein Change kann also raus!
|
This is awesome news! I will review your pull request this weekend and then merge it in. Looks like we are going for our initial |
|
@bennyn: Schau dir besonders die Changes in FileInfoReader an! Den Code habe ich aus den Lambdas mit Readern nachgebaut. Hoffentlich funktioniert noch alles. Die restlichen Inline-Funktionen konnte mir NetBeans via Hint zurueckkonvertieren. |
| for (String line = reader.readLine(); line != null; line = reader.readLine()) { | ||
| lines.add(line); | ||
| } | ||
| reader.close(); |
There was a problem hiding this comment.
Shouldn't this reader be closed in a finally block or placed in a try-with-resources block?
There was a problem hiding this comment.
We can check how it's done in Apache Commons' IOUtils.readLines.
|
@Shredder121: I added try-with-resources. See the additional commit f738fee on the branch. Now it's also only one point of failure or more positive: a better implementation without the readers could be implemented there. |
| <de-markiewb-netbeans-plugins-eclipse-formatter.useProjectSettings>true</de-markiewb-netbeans-plugins-eclipse-formatter.useProjectSettings> | ||
| </properties> | ||
| </project-shared-configuration> | ||
| <?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
It seems that the line ending is changed.
|
@junichi11 / @bennyn / @Shredder121 : Feel free to checkout the branch and fix the issues for yourself, if they are only minor ones. |
|
@junichi11: I do not mind and I do not misunderstand it. It's fine. I guess you are busy too. g |
|
@markiewb Sorry for being so late with reviewing it! But as you said, everyone's busy. I finally reviewed your changes, so you get a big DANKESCHÖN! 😄 I will add the Next thing will then be plugin certification. Thank you so much @markiewb. 🍻 |
Rewrote Java 8 code to be compatible with Java 7
|
@bennyn: Gern geschehen! Only with a public release and the placement at the plugin center your plugin gets the attention of the users. Your invested work should not be wasted, that's why I helped you. |
Hi, have a look at this pull-request to transform the code to Java7. You did not use so much JDK8-specifics, so it was "easy" to transform. Try it out.
Using this you could provide a version for NB8.1/8.0 the plugin portal. #42