Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty commit to trigger PR workflows #4

Open
wants to merge 262 commits into
base: main
Choose a base branch
from
Open

Empty commit to trigger PR workflows #4

wants to merge 262 commits into from

Conversation

weresch
Copy link
Owner

@weresch weresch commented Jun 28, 2024

Thank you for contributing to the CF CLI! Please read the following:

  • Please make sure you have implemented changes in line with the contributing guidelines
  • We're not allowed to accept any PRs without a signed CLA, no matter how small.
    If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
  • All new code requires tests to protect against regressions.
  • Contributions must be made against the appropriate branch. See the contributing guidelines
  • Contributions must conform to our style guide. Please reach out to us if you have questions.

Note: Please create separate PR for every branch (main, v8 and v7) as needed.

Description of the Change

We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.

Why Is This PR Valuable?

What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?

Applicable Issues

List any applicable GitHub Issues here

How Urgent Is The Change?

Is the change urgent? If so, explain why it is time-sensitive.

Other Relevant Parties

Who else is affected by the change?

sweinstein22 and others added 30 commits February 7, 2022 09:10
@sweinstein22 @monamohebbi
Consolidate version checking to use ccversion file
f316ed6 
We noticed the constant for minimum v3 versioning was not being used
anywhere and also did not accurately reflect the minimum CAPI version
required for the V8 CLI, which the CLI version that supports V3 only
uses. We replaced it with the accurate minimum version based on a
version checker that is being used in login and auth and consolidated
references to only use the minimum version constant.

Co-authored-by: Sarah Weinstein <sweinstein@pivotal.io>
Co-authored-by: Mona Mohebbi <mmohebbi@pivotal.io>
@jdgonzaleza
[Feature] support HTTP/2 cf command (cloudfoundry#2230)
d5af404 
[reason] Renaming "protocol" column to "app-protocol"
in the destination table of the cf route command

Co-authored-by: Hector Calderon <hecalderon@vmware.com>
@jdgonzaleza
[Feature] Rename flag to app-protocol in map-route (cloudfoundry#2231)
a8b846e 
Currently the cli already has a flag named destination-protocol
and in order to have consistency we need to rename it to app-protocol

Co-authored-by: Hector Calderon <hecalderon@vmware.com>
@jdgonzaleza
[Feature] Add app-protocol to cf routes command output (cloudfoundry#…
e446430 
…2234)

Currently we do not show the app-protocol in the output
of the cf routes command, so a new column must be added
to the output. Also, the apps mapped to the route should
be displayed in the apps column and must be separated with commas.

Co-authored-by: Hector Calderon <hecalderon@vmware.com>
Merge pull request cloudfoundry#2249 from cloudfoundry/sustaining/bac…
e09a9d7 
…kporting-to-v8.1

[Sustaining] Backporting to v8 branch
@a-b
Merge remote-tracking branch 'origin/master' into v8
a04e7f4
@a-b
Bump version to 8.2.0
fd8fbca
@mariash
Update the tip for security groups
93c1943 
When users have dynamic ASG's feature enabled they don't need to
restart/restage their application for security group updates to take and
effect.
Merge pull request cloudfoundry#2256 from cloudfoundry/asgs-tip-v8
da64a18 
Update the tip for security groups
@gururajsh
[Feature] Upgrade Golang version from 1.16 to 1.17 Some high security…
a366871 
… issues have been solved in the newer versions of go. Moreover, there are some security enhancements coming from 1.17.
@gururajsh
[Sustaining] Updating go files with linter doing gofmt -l -w .
336aa0a 
Co-authored-by: Shwetha Gururaj <gururajsh@vmware.com>
@jdgonzaleza @pivotalgeorge
[Feature/tas-e-51] Update destination Protocol command (cloudfoundry#…
54153cb 
…2260)

* Adds new update-destination command

update destination app-protocol for a route
so that the new protocol is used for all
communication from and to the app using that route

* Upgrades bundler version in integration go_ruby app

Co-authored-by: Cristhian Pena <cpena@vmware.com>
Co-authored-by: George Gelashvili <ggelashvili@vmware.com>
Bumps BUILD_VERSION
bef87cf
@a-b
[Bugfix] Idempotency when trying to create a service twice
2b4e144 
It was implemented everything for this feature but the error handler when
CAPI V3 answered with a 422 status code with the message
the service instance name is taken.
@matt-royal
Fix selfcontained tests failing due to /whoami
375a05c 
Authored-by: Matt Royal <mroyal@vmware.com>
@matt-royal @davewalter @akrishna90
Send Authorization header for logcache on CFonK8s
504d4e8 
- Extract "Authorization" header logic for CFonK8s into
  api/shared/WrapForCFOnK8sAuth and refactor existing code to use this
- Move LogCache client into api/logcache to avoid a cyclic import
- Bubble out error from logcache.NewClient
- New selfcontained tests for logcache request changes

Co-authored-by: Matt Royal <mroyal@vmware.com>
Co-authored-by: Dave Walter <walterda@vmware.com>
Co-authored-by: Ashwin Krishna <krishnaas@vmware.com>
@matt-royal
Fix selfcontained tests failing due to /whoami (cloudfoundry#2266)
45447b3 
Authored-by: Matt Royal <mroyal@vmware.com>
@reedr3
Merge pull request cloudfoundry#2267 from eirini-forks/add-auth-to-logs
aad94f8 
Add auth header to logcache API requests for cf-on-k8s
@dependabot @reedr3
Bump github.com/docker/distribution
470d992 
Bumps [github.com/docker/distribution](https://github.com/docker/distribution) from 2.6.0-rc.1.0.20171109224904-e5b5e44386f7+incompatible to 2.8.0+incompatible.
- [Release notes](https://github.com/docker/distribution/releases)
- [Commits](https://github.com/docker/distribution/commits/v2.8.0)

---
updated-dependencies:
- dependency-name: github.com/docker/distribution
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@a-b @pivotalgeorge
[v8] Online release process with Github Actions (cloudfoundry#2265)
d201936 
* Add Build-Sign-Release workflow

Commit summary below

Current state of CF CLI release infrastructure is offline and quite
outdated. To make our release process more transparent and inclusive we
decided to move build, signing and release processes online to Github Actions.
* Split out release/upload part of workflow
* Add capabilities to release workflow

At this point working in a workflow separate from build, for separation
of concerns between building&signing, and releasing.

This is a squashed commit of the gha-allplatforms branch, consisting of
the following changes :

- Upload mac installer to S3
- include mac installer in github release
- retrieve mac binaries in release job
- add write permission to github release job
- Add linux packages, and simplify CLAW upload steps
- Switch to sync action to support simpler CLAW S3 upload step
- Add linux packages to GH Release
- Update artifact names in release jobs
- aws s3 ls to debug s3 upload
- bump aws s3 sync to non-default-region change

* Updated for build, release, and units workflows
* Add update-repos workflow

Update-repos workflow is in charge of updating and signing on a
repository level. This workflow should be triggered towards the end of
the release process after all packages are available via distribution
network (after CLAW update). It will update the following repositories:

- Homebrew formula in homebrew-tap git repository
- RPM repo hosted on S3
- Debian repo hosted on S3

Current implementations of the update-repos workflow is matching offline
release process.

Following updates are recommended:

- Implement backup and disaster recovery procedure

- Debian
  - fill license and vendor fields
- RPM
  - sign on the repo level
- Homebrew
  - add arm architecture

* Release pipelines updates
* Removes/Cleans comments

Also, small change to sign-windows-binary.ps1 as
that step was already being done in the sign job

* Update github actions secrets template

for use with the set-github-actions-env-vars.sh script,
or the github cli's 'secret set' subcommand directly

Co-authored-by: Alexander Berezovsky <aberezovsky@vmware.com>
Co-authored-by: George Gelashvili <ggelashvili@vmware.com>
Co-authored-by: Juan Diego Gonzalez <gojuan@vmware.com>
Signed-off-by: Pete Levine <lpete@vmware.com>
@a-b
Bump version to 8.4.0
b3bd35f
@a-b
Testing hydrabroker with new dependency versions
9184b5d
@a-b
Ginkgo 2.0 bump
2855a1b
@a-b @gururajsh
Add GHA capability to release Apple ARM
0c5acc1 
Support other CLI major versions
Major Build-Sign-Upload workflow refactor

Co-authored-by: Shwetha Gururaj <gururajsh@vmware.com>
Co-authored-by: Juan Diego Gonzalez <gojuan@vmware.com>
Signed-off-by: Juan Diego Gonzalez <gojuan@vmware.com>
Bump Sinatra version for fixtures example-app from 2.0.4 to 2.2.0
14792b6 
Co-authored by: George Gelashvili <ggelashvili@vmware.com>
Revert "Bump Sinatra version for fixtures example-app from 2.0.4 to 2…
dd9a0c0 
….2.0"

This reverts commit 14792b6.

We will follow the PR flow as always.
@gururajsh @a-b
Skipping SSL validation tests for macOS
5abaa24 
Starting golang 1.18 system APIs are used for certificate verification
on macOS instead of built-in go verifier. Which makes behavior similar
to Windows. Since we are skipping this test for Windows due to
difficulties with execution order we believe it's fair to skip it in
macOS too and rely on Linux test.

References:
- [Changes to x509 in Go 1.18 conversation](https://groups.google.com/g/golang-nuts/c/RGghq2gTWss/m/7GsudTfCAgAJ)
- https://cs.opensource.google/go/go/+/master:src/crypto/x509/root_darwin.go;l=52
- https://cs.opensource.google/go/go/+/master:src/crypto/x509/verify.go;l=766

Co-authored-by: Alexander Berezovsky <aberezovsky@vmware.com>
@gururajsh @a-b
Bump golang to 1.18
9bf740f 
Co-authored-by: Alexander Berezovsky <aberezovsky@vmware.com>
@gururajsh @a-b
Parse pipelines go version from go.mod
9ee314c 
We want to use single source of truth go.mod, instead of configuration
scattered across multiple places.

Co-authored-by: Alexander Berezovsky <aberezovsky@vmware.com>
Implements new command share-route
3346dae 
This command is used for sharing a route in between two spaces
in order to facilitate the movement of apps in between
spaces.

Co-authored-by: Juan Diego Gonzalez <gojuan@vmware.com>
ctlong and others added 29 commits April 30, 2024 14:18
@ctlong
feat: Add cpu entitlement to app process table (cloudfoundry#2840)
5c2a1f4 
Shows the new CPU Entitlement metric in the app process table, under the
heading `cpu entitlement`. If CPU Entitlement metrics are not available
(e.g. deployment does not support it, app is stopped, etc.) for a
process instance, then that row will show an empty value.

Signed-off-by: Rebecca Roberts <rebecca.roberts@broadcom.com>
@dependabot
Bump golang.org/x/net from 0.22.0 to 0.24.0 (cloudfoundry#2846)
63a9fc2 
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.22.0 to 0.24.0.
- [Commits](golang/net@v0.22.0...v0.24.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump code.cloudfoundry.org/go-loggregator/v9 from 9.2.0 to 9.2.1 (clo…
93db68e 
…udfoundry#2870)

Bumps [code.cloudfoundry.org/go-loggregator/v9](https://github.com/cloudfoundry/go-loggregator) from 9.2.0 to 9.2.1.
- [Release notes](https://github.com/cloudfoundry/go-loggregator/releases)
- [Commits](cloudfoundry/go-loggregator@v9.2.0...v9.2.1)

---
updated-dependencies:
- dependency-name: code.cloudfoundry.org/go-loggregator/v9
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@vchrisb
[Bugfix] Idempotency when trying to share a service twice (cloudfound…
1240228 
…ry#2874)
@a-b
Switch from repo secrets to vars [v8] (cloudfoundry#2841)
74f1353 
* Switch from repo secrets to vars
@dependabot
Bump github.com/onsi/ginkgo/v2 from 2.17.1 to 2.17.3 (cloudfoundry#2891)
80bbba9 
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.17.1 to 2.17.3.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.17.1...v2.17.3)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/onsi/gomega from 1.33.0 to 1.33.1 (cloudfoundry#2894)
f33ce51 
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.33.0 to 1.33.1.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.33.0...v1.33.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump golang.org/x/net from 0.24.0 to 0.25.0 (cloudfoundry#2895)
1ea3117 
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.24.0 to 0.25.0.
- [Commits](golang/net@v0.24.0...v0.25.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/cyphar/filepath-securejoin from 0.2.4 to 0.2.5 (cloud…
98e78d1 
…foundry#2904)

Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin) from 0.2.4 to 0.2.5.
- [Release notes](https://github.com/cyphar/filepath-securejoin/releases)
- [Commits](cyphar/filepath-securejoin@v0.2.4...v0.2.5)

---
updated-dependencies:
- dependency-name: github.com/cyphar/filepath-securejoin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@moleske
Use macOS 13 for unit tests instead of macOS 11 (cloudfoundry#2913)
c137b93 
- macOS 11 is deprecated per https://github.com/actions/runner-images as
  of this commit
@moleske
Bump code.cloudfoundry.org/tlsconfig to latest (cloudfoundry#2916)
e4eb09f 
- dependabot doesn't do well with non versioned dependencies
- will resolve the annyoing cve warning in goland ide
@chinigo
Install ginkgo "out of the box" (v8 branch) (cloudfoundry#2927)
3eaa855 
* Install ginkgo "out of the box"

This change installs the version of Ginkgo specified in go.mod, modifies
the Makefile to do this before each flavor of test, and simplifies the
CI tasks that invoke these tests.

Prior to this change, the Makefile assumes the presence of a
system-level installation of Ginkgo. That installation of Ginkgo will
not necessarily match the version specified in our go.mod.

This introduces the (slight) possibility of subtle differences in the
behavior of the test library. It also complicates spinning up a new
environment, either for a developer or in CI.

* No longer install gomega matchers as a system-level dependency

These matchers are imported as needed in the test files that need them.
There is no need to install them as a system-level dependency, so let's
not.
@Samze
Remove custom linter (cloudfoundry#2928)
a8be584
@dependabot
Bump github.com/fatih/color from 1.16.0 to 1.17.0 (cloudfoundry#2924)
d76a6c6 
Bumps [github.com/fatih/color](https://github.com/fatih/color) from 1.16.0 to 1.17.0.
- [Release notes](https://github.com/fatih/color/releases)
- [Commits](fatih/color@v1.16.0...v1.17.0)

---
updated-dependencies:
- dependency-name: github.com/fatih/color
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@f-blass
Fix race condition in config handling (v8) (cloudfoundry#2931)
9f67c62 
* Ignore non-existent files when deleting temp-files

* Only delete files older than 5min
@joaopapereira
Fix linting issues (cloudfoundry#2940)
9db03af 
- Add new action that will be responsible for running the linter
- Fix all the linter issues
- Remove deprecated linters

Signed-off-by: João Pereira <joaod@vmware.com>
@a-b
Retry flaky ssh test on mac worker (cloudfoundry#2942)
4fb7f7c 
- Simplified CLI SSH Suit execution to run togetheer with other non-plugin tests

https://onsi.github.io/ginkgo/#repeating-spec-runs-and-managing-flaky-specs
@gururajsh
Add version check to CLAW update [v8] (cloudfoundry#2907)
481c7e3 
* Add version check to CLAW update
@dependabot
Bump golangci/golangci-lint-action from 3 to 6 (cloudfoundry#2948)
729e8d2 
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3 to 6.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v3...v6)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/distribution/reference from 0.5.0 to 0.6.0 (cloudfoun…
d681bd4 
…dry#2947)

Bumps [github.com/distribution/reference](https://github.com/distribution/reference) from 0.5.0 to 0.6.0.
- [Release notes](https://github.com/distribution/reference/releases)
- [Commits](distribution/reference@v0.5.0...v0.6.0)

---
updated-dependencies:
- dependency-name: github.com/distribution/reference
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
--- (cloudfoundry#2946)
e55f6a1 
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/onsi/ginkgo/v2 from 2.18.0 to 2.19.0 (cloudfoundry#2952)
a5ad93b 
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.18.0 to 2.19.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.18.0...v2.19.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@joaopapereira @gururajsh
Min capi [v8] (cloudfoundry#2963)
95bcf32 
* Enable tests against minimum version of capi
* Enable dispatching workflows via github UI

Signed-off-by: João Pereira <joaod@vmware.com>
Co-authored-by: Shwetha Gururaj <gururajsh@vmware.com>
@dependabot
Bump golang.org/x/text from 0.15.0 to 0.16.0 (cloudfoundry#2958)
b78406a 
Bumps [golang.org/x/text](https://github.com/golang/text) from 0.15.0 to 0.16.0.
- [Release notes](https://github.com/golang/text/releases)
- [Commits](golang/text@v0.15.0...v0.16.0)

---
updated-dependencies:
- dependency-name: golang.org/x/text
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@joaopapereira
[v8] Fix pr issues (cloudfoundry#2973)
56666f0 
* Ensure correct pool is being used for PRs

* Use integration workflow directly from unit tests

* Provide secret directly instead of using env variable

* Remove check for Server header in curl request tests

Starting on version 1.181.0, capi will no longer report the version of
the nginx server to ensure that no information is leaked.
For more information check cloudfoundry/capi-release#406

* Change in response from UAA

Starting on version 76.26.0 of UAA a change was made that changes the
behavior more context in cloudfoundry/uaa#2545

Signed-off-by: João Pereira <joaod@vmware.com>
@gururajsh
Remove Content-Type header while downloading droplets [v8] (cloudfoun…
01d27c5 
…dry#2975)

Remove Content-Type header for download droplet
@weresch
Empty commit to trigger PR workflows
64b7b1b
@weresch
Empty commit to trigger PR workflows again
7f4f664
@weresch
Add a comment to see if PR workflow is triggered
1734052
@weresch weresch changed the base branch from v8 to main June 28, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.