Do not display tooltips in mobile or Cordova, for Jira issue 174 #3791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves https://wevoteusa.atlassian.net/browse/WV-174 Removes sign in with Facebook from Cordova Android (temporary).
Resolves https://wevoteusa.atlassian.net/browse/WV-174 Removes sign in with Facebook from Cordova Android (temporary).
Resolves https://wevoteusa.atlassian.net/browse/WV-174 Removes sign in with Facebook from Cordova Android (temporary).
Resolves https://wevoteusa.atlassian.net/browse/WV-174 Removes sign in with Facebook from Cordova Android (temporary).
|
👍 Thank you @SailingSteve! |
DaleMcGrew
reviewed
Dec 7, 2023
| @@ -24,7 +25,7 @@ function ToolBar (params) { | |||
| className="u-no-underline" | |||
| url="https://twitter.com/WeVote" | |||
| target="_blank" | |||
| body={( | |||
| body={isMobileScreenSize() ? (<span />) : ( | |||
There was a problem hiding this comment.
@SailingSteve Instead of just showing a span in mobile screensize, could we show the IconButton block without the Tooltip wrapper? (for all of the places in this file where you set isMobileScreenSize to remove the Tooltip) I could be mistaken, but it looks like your change removes the icon in mobile view as well as the Tooltip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://wevoteusa.atlassian.net/browse/WV-174
Removes sign in with Facebook from Cordova Android (temporary).