[WV-659] & [WV-660] VoterPositionEntryAndDisplay && VoterPositionEditNameAndPhotoModal #4228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… click "What's your opinion?" & VoterPositionEntryAndDisplay: Open modal to edit name & add photo [WV-659] & [WV-660] Implement VoterPositionEntryAndDisplay with Related Modals - Created a new functional component `VoterPositionEntryAndDisplay` to manage user opinions and enable modal interactions. - Implemented two related modals: 1. "What's your opinion?" modal for adding or editing opinions (`WebApp/src/js/components/PositionItem/VoterPositionEntryAndDisplay.jsx`). 2. Edit Name & Add Photo modal for updating user details (`WebApp/src/js/components/PositionItem/VoterPositionEditNameAndPhotoModal.jsx`). - Managed state for visibility, opinion text, and user details dynamically using `VoterStore`. - Styled components to align with the design system, utilizing `DesignTokenColors` for consistent theming. - Both modals were included in the same commit since one opens the other, ensuring seamless integration. Notes: - Future updates to each modal can be made independently in different branches i jest decided to show it and push commit together for this two modals.
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
| <div className={classes.container}> | ||
| <span className={classes.label}>Opinion visible to:</span> | ||
| <FormControl className={classes.formControl}> | ||
| <Select |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
…PostPublicDropdown.jsx Apply fixes and improve accessibility in ActivityPostPublicDropdown.jsx
Screen.Recording.2025-01-19.at.2.50.50.PM.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WV-659 & WV-660 VoterPositionEntryAndDisplay && VoterPositionEditNameAndPhotoModal
VoterPositionEntryAndDisplayto manage user opinions and enable modal interactions.VoterPositionEditNameAndPhotoModalto user photo and name.WebApp/src/js/components/PositionItem/VoterPositionEntryAndDisplay.jsx).WebApp/src/js/components/PositionItem/VoterPositionEditNameAndPhotoModal.jsx).DesignTokenColorsfor consistent theming.Notes:
Both modals were included in the same commit since one opens the other.