Add more e2e tests #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandito
force-pushed
the
nandor/pan-330-add-more-e2e-tests
branch
2 times, most recently
from
5deecfe to
b3f8550
Compare
havardholvik
approved these changes
Oct 17, 2023
Collect samples by counting the frames and make some stats. Check if the minimun fps is greater than 1, so the video is not frozen. This test cannot run in WebKit, as it does not provide any API to count frames.
Let's try to use 80% of the logical CPU cores.
nandito
force-pushed
the
nandor/pan-330-add-more-e2e-tests
branch
from
b3f8550 to
022350a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add e2e tests:
Note: The
yarn.lockfile of the sample-app was previously ignored in the.gitignore, but it is no longer ignored. Therefore, we can now cache it on the CI and make the prepare step a bit faster.Test plan