Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser-sdk: Add "meeting_end" embed event #116

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

havardholvik
Copy link
Contributor

@havardholvik havardholvik commented Mar 19, 2024

Description

Allow customers to take action whenever a meeting has been explicitly ended by the host.

Testing

Check out https://github.com/whereby/pwa/pull/4006. Ensure you have a .env set up with a room url which works with Storybook.

  1. yarn dev
  2. Visit http://localhost:6006/?path=/story/examples-pre-built-ui--whereby-embed-element-example
  3. Join room, then end meeting for all.
  4. Verify "Meeting ended: TRUE" is present in the top

Screenshots/GIFs (if applicable)

Screenshot 2024-03-19 at 09 41 51

Checklist

  • My code follows the project's coding standards.
  • Prefixed the PR title and commit messages with the service or package name
  • I have written unit tests (if applicable).
  • I have updated the documentation (if applicable).
  • By submitting this pull request, I confirm that my contribution is made
    under the terms of the MIT license.

Allow customers to take action whenever a meeting has been explicitly
ended by the host.
Copy link

changeset-bot bot commented Mar 19, 2024

🦋 Changeset detected

Latest commit: 0092158

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@whereby.com/browser-sdk Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@richtrwhereby richtrwhereby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me with the instructions provided 🚀

@nrolls nrolls merged commit cee374e into main Apr 26, 2024
3 checks passed
@nrolls nrolls deleted the holvik/meeting_end_embed_event branch April 26, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants