core: handle room_joined errors #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d4937dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kevinwhereby
changed the title
Currently for any error except `room_locked`, the SDK thinks it joins the room successfully. Rather than explicily handle all possible errors, we can fall back to this handler and add more specific cases as they are required by the SDK
kevinwhereby
force-pushed
the
kevinhanna/handle-room-join-errors
branch
from
1295e67 to
0de5018
Compare
We don't return room_full without the isLocked: true
kevinwhereby
force-pushed
the
kevinhanna/handle-room-join-errors
branch
from
95c9401 to
d4937dd
Compare
nandito
approved these changes
Mar 21, 2024
nandito
changed the title
nandito
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary:
Currently for any error except
room_locked, the SDK thinks it joinsthe room successfully. Rather than explicily handle all possible errors,
we can fall back to this handler and add more specific cases as they are
required by the SDK
Related Issue:
https://linear.app/whereby/issue/COB-522/auto-stop-captioner
We need to know if the room join fails, so we can kill the captioning process
Testing
To see the error, make a small room and try to join it with 5 SDK clients. using the example apps If you keep an eye on the room connection status you'll see it says 'connected' for all clients even though the 5th is refused entry due to "room_full"
Now build this branch and run the same test, you'll see the last client changes it's roomConnectionStatus to 'disconnected' and sets the error to "room_full"
Screenshots/GIFs (if applicable)
Checklist
under the terms of the MIT license.
Additional Information